Fix treatment of slashes (path separator) by history command #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the history pruning treatment of a slash
character in the history followed by the name of the history
command.
The purpose of pruning is to avoid recursion in the history
rewind, so history lines with a history command in them are
pruned away in the search.
With the history command named as "-", previously a history
line like:
find / --option
would have been pruned (too aggressively). The change trims
whitespace after first considering the case of whitespace
separating a slash and the name of the history command.
A few basic unit tests for the history command are also added
with this commit.
rakitzis
force-pushed
the
fix-history-slash
branch
from
5b41300 to
48fbbc7
Compare
|
Fixes #104 |
|
thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the history pruning treatment of a slash character in the history followed by the name of the history command.
The purpose of pruning is to avoid recursion in the history rewind, so history lines with a history command in them are pruned away in the search.
With the history command named as "-", previously a history line like:
would have been pruned (too aggressively). The change trims whitespace after first considering the case of whitespace separating a slash and the name of the history command.
A few basic unit tests for the history command are also added with this commit.