Get orders by Customer Id #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updated the Readme with Tips to bring the Service up.
order-service/src/main/java/com/example/orderservice/web/controllers/OrderController.java
Outdated
Show resolved
Hide resolved
…added and updated to application yaml and application-local properties and added readme.md to start application locally.
rajadilipkolli
requested changes
Oct 3, 2023
order-service/src/main/java/com/example/common/dtos/OrderResponse.java
Outdated
Show resolved
Hide resolved
order-service/src/main/java/com/example/common/dtos/OrderResponse.java
Outdated
Show resolved
Hide resolved
order-service/src/main/java/com/example/common/dtos/OrderResponse.java
Outdated
Show resolved
Hide resolved
order-service/src/main/java/com/example/orderservice/web/controllers/OrderController.java
Show resolved
Hide resolved
| @@ -8,14 +8,14 @@ Licensed under MIT License Copyright (c) 2023 Raja Kolli. | |||
|
|
|||
| import static com.example.orderservice.utils.AppConstants.PROFILE_TEST; | |||
| import static org.assertj.core.api.Assertions.assertThat; | |||
| import static org.junit.jupiter.api.Assertions.assertEquals; | |||
rajadilipkolli
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Thank @manepullavamsi for your first contribution. Awaiting more pull requests from you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we would be fetching the orders based on customer Id and we would be taking customer Id and the pageRequest and will respond back with the orders based on Page Number and Page Size.