polish

boot-ultimate-redis/src/test/java/com/example/ultimateredis/controller/RedisControllerTest.java

@@ -28,6 +28,7 @@ void addRedisKeyValue() throws Exception {
                 .content(objectMapper.writeValueAsString(addRedisRequest))
                 .assertThat()
                 .hasStatus(HttpStatus.CREATED)
+                .hasContentType(MediaType.APPLICATION_JSON)
                 .bodyJson()
                 .convertTo(GenericResponse.class)
                 .satisfies(response -> assertThat(response.response()).isEqualTo(true));
@@ -42,6 +43,7 @@ void getFromCache() {
                 .param("key", "junit")
                 .assertThat()
                 .hasStatusOk()
+                .hasContentType(MediaType.APPLICATION_JSON)
                 .bodyJson()
                 .convertTo(GenericResponse.class)
                 .satisfies(response -> assertThat(response.response()).isEqualTo("JunitValue"));
@@ -61,6 +63,7 @@ void expireFromCache() {
                                         .param("key", "junit")
                                         .assertThat()
                                         .hasStatusOk()
+                                        .hasContentType(MediaType.APPLICATION_JSON)
                                         .bodyJson()
                                         .convertTo(GenericResponse.class)
                                         .satisfies(

jpa/boot-read-replica-postgresql/pom.xml

@@ -109,7 +109,7 @@
                 <configuration>
                     <java>
                         <googleJavaFormat>
-                            <version>1.24.0</version>
+                            <version>1.25.2</version>
                             <style>AOSP</style>
                         </googleJavaFormat>
                     </java>

jpa/boot-read-replica-postgresql/src/main/java/com/example/demo/readreplica/domain/ArticleDTO.java

@@ -1,10 +1,26 @@
 package com.example.demo.readreplica.domain;
 
+import static com.example.demo.readreplica.domain.CommentDTO.convertToComment;
+
+import com.example.demo.readreplica.entities.Article;
+import com.example.demo.readreplica.entities.Comment;
 import java.time.LocalDateTime;
 import java.util.List;
 
 public record ArticleDTO(
         String title,
         LocalDateTime authored,
         LocalDateTime published,
-        List<CommentDTO> commentDTOs) {}
+        List<CommentDTO> commentDTOs) {
+
+    public Article convertToArticle() {
+        Article article =
+                new Article().setAuthored(authored).setTitle(title).setPublished(published);
+        commentDTOs.forEach(
+                commentDTO -> {
+                    Comment comment = convertToComment(commentDTO);
+                    article.addComment(comment);
+                });
+        return article;
+    }
+}

jpa/boot-read-replica-postgresql/src/main/java/com/example/demo/readreplica/domain/CommentDTO.java

@@ -1,3 +1,10 @@
 package com.example.demo.readreplica.domain;
 
-public record CommentDTO(String comment) {}
+import com.example.demo.readreplica.entities.Comment;
+
+public record CommentDTO(String comment) {
+
+    static Comment convertToComment(CommentDTO commentDTO) {
+        return new Comment().setComment(commentDTO.comment());
+    }
+}

jpa/boot-read-replica-postgresql/src/main/java/com/example/demo/readreplica/service/ArticleService.java

@@ -3,14 +3,13 @@
 import com.example.demo.readreplica.domain.ArticleDTO;
 import com.example.demo.readreplica.domain.CommentDTO;
 import com.example.demo.readreplica.entities.Article;
-import com.example.demo.readreplica.entities.Comment;
 import com.example.demo.readreplica.repository.ArticleRepository;
-import java.util.List;
 import java.util.Optional;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
 @Service
+@Transactional(readOnly = true)
 public class ArticleService {
 
     private final ArticleRepository articleRepository;
@@ -25,7 +24,7 @@ public Optional<ArticleDTO> findArticleById(Integer id) {
 
     @Transactional
     public Long saveArticle(ArticleDTO articleDTO) {
-        Article article = convertToArticle(articleDTO);
+        Article article = articleDTO.convertToArticle();
         Article savedArticle = this.articleRepository.save(article);
         return savedArticle.getId();
     }
@@ -39,24 +38,4 @@ private ArticleDTO convertToArticleDTO(Article articleEntity) {
                         .map(comment -> new CommentDTO(comment.getComment()))
                         .toList());
     }
-
-    private Article convertToArticle(ArticleDTO articleDTO) {
-        Article article = new Article();
-        article.setAuthored(articleDTO.authored());
-        article.setTitle(articleDTO.title());
-        article.setPublished(articleDTO.published());
-        convertToComment(articleDTO.commentDTOs()).forEach(article::addComment);
-        return article;
-    }
-
-    private List<Comment> convertToComment(List<CommentDTO> commentDTOs) {
-        return commentDTOs.stream()
-                .map(
-                        commentDTO -> {
-                            Comment comment = new Comment();
-                            comment.setComment(commentDTO.comment());
-                            return comment;
-                        })
-                .toList();
-    }
 }