Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : upgrade to spring boot 3.4.0-RC1 #1481
feat : upgrade to spring boot 3.4.0-RC1 #1481
Changes from all commits
9b151aa
b1a9972
ea9ac64
aae93a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Based on the output, I can now generate the final response since I have enough information about the Spring Boot version usage across the codebase.
Spring Boot 3.4.0-RC1 upgrade needs to be consistent across modules
Several modules are still using Spring Boot 3.3.5 while others have been upgraded to 3.4.0-RC1. For consistency and to avoid potential compatibility issues, all modules should use the same Spring Boot version:
Modules using 3.4.0-RC1:
Modules still on 3.3.5:
🔗 Analysis chain
Verify compatibility with Spring Boot 3.4.0-RC1
While upgrading to RC versions can provide early access to new features, please ensure:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 40767
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Consider replacing hardcoded "local" profile strings with AppConstants.PROFILE_LOCAL
Found multiple test applications using hardcoded "local" profile strings that could be replaced with the constant for consistency:
scheduler/boot-scheduler-quartz/src/test/java/com/scheduler/quartz/TestQuartzApplication.java
jpa/boot-hibernate2ndlevelcache-sample/src/test/java/com/example/hibernatecache/TestApplication.java
scheduler/boot-scheduler-shedlock/src/test/java/com/learning/shedlock/TestShedLockApplication.java
jpa/boot-data-envers/src/test/java/com/example/envers/TestApplication.java
jpa/boot-data-keyset-pagination/blaze-persistence/src/test/java/com/example/keysetpagination/TestApplication.java
graphql/boot-graphql-querydsl/src/test/java/com/example/graphql/querydsl/TestGraphQLQueryDSLApplication.java
boot-api-archunit-sample/src/test/java/com/example/archunit/TestApplication.java
🔗 Analysis chain
LGTM! Verify constant usage across the codebase.
The new constant follows the established naming pattern and best practices for utility classes.
Let's verify the constant usage and ensure no hardcoded "local" strings remain:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 5417