feat : sonar fixes

rajadilipkolli · Feb 9, 2024 · e8515c5 · e8515c5
1 parent 9536c4d
commit e8515c5
Show file tree

Hide file tree

Showing 13 changed files with 32 additions and 25 deletions.
diff --git a/graphql/boot-graphql-querydsl/pom.xml b/graphql/boot-graphql-querydsl/pom.xml
@@ -316,7 +316,7 @@
                 <configuration>
                     <java>
                         <palantirJavaFormat>
-                            <version>2.38.0</version>
+                            <version>2.39.0</version>
                         </palantirJavaFormat>
                         <importOrder />
                         <removeUnusedImports />

diff --git a/graphql/boot-graphql-webflux/pom.xml b/graphql/boot-graphql-webflux/pom.xml
@@ -227,7 +227,7 @@
 				<configuration>
 					<java>
 						<palantirJavaFormat>
-							<version>2.38.0</version>
+							<version>2.39.0</version>
 						</palantirJavaFormat>
 						<importOrder />
 						<removeUnusedImports />

diff --git a/...hql-webmvc/src/main/java/com/example/graphql/mapper/NewPostRequestToPostEntityMapper.java b/...hql-webmvc/src/main/java/com/example/graphql/mapper/NewPostRequestToPostEntityMapper.java
@@ -61,6 +61,15 @@ default void afterMapping(
                                                     .contains(tagEntity.getTagName()))
                             .toList();
 
+            for (TagEntity tagEntity : tagEntitiesToUpdate) {
+                for (TagsRequest tagsRequest : newPostRequest.tags()) {
+                    if (tagEntity.getTagName().equalsIgnoreCase(tagsRequest.tagName())) {
+                        tagEntity.setTagDescription(tagsRequest.tagDescription());
+                        break;
+                    }
+                }
+            }
+
             List<TagsRequest> tagEntitiesToInsert =
                     newPostRequest.tags().stream()
                             .filter(

diff --git a/...data-envers/src/main/java/com/example/envers/config/DatasourceProxyBeanPostProcessor.java b/...data-envers/src/main/java/com/example/envers/config/DatasourceProxyBeanPostProcessor.java
@@ -23,11 +23,11 @@ public class DatasourceProxyBeanPostProcessor implements BeanPostProcessor {
 
     @Override
     public Object postProcessAfterInitialization(@NonNull Object bean, @NonNull String beanName) {
-        if (bean instanceof DataSource && !(bean instanceof ProxyDataSource)) {
+        if (bean instanceof DataSource dataSource && !(bean instanceof ProxyDataSource)) {
 
             final ProxyFactory factory = new ProxyFactory(bean);
             factory.setProxyTargetClass(true);
-            factory.addAdvice(new ProxyDataSourceInterceptor((DataSource) bean));
+            factory.addAdvice(new ProxyDataSourceInterceptor(dataSource));
             return factory.getProxy();
         }
         return bean;

diff --git a/...t-pagination/src/main/java/com/example/keysetpagination/services/EntitySpecification.java b/...t-pagination/src/main/java/com/example/keysetpagination/services/EntitySpecification.java
@@ -15,7 +15,6 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
-import java.util.stream.Collectors;
 import java.util.stream.Stream;
 import org.springframework.data.jpa.domain.Specification;
 import org.springframework.stereotype.Component;
@@ -29,7 +28,7 @@ public Specification<T> specificationBuilder(SearchCriteria[] searchCriteria) {
                     Stream.of(searchCriteria)
                             .filter(Objects::nonNull)
                             .map(this::createSpecification)
-                            .collect(Collectors.toList());
+                            .toList();
 
             return Specification.allOf(specifications);
         }

diff --git a/...ot-jpa-locks/src/main/java/com/example/locks/config/DatasourceProxyBeanPostProcessor.java b/...ot-jpa-locks/src/main/java/com/example/locks/config/DatasourceProxyBeanPostProcessor.java
@@ -23,11 +23,11 @@ public class DatasourceProxyBeanPostProcessor implements BeanPostProcessor {
 
     @Override
     public Object postProcessAfterInitialization(@NonNull Object bean, @NonNull String beanName) {
-        if (bean instanceof DataSource && !(bean instanceof ProxyDataSource)) {
+        if (bean instanceof DataSource dataSource && !(bean instanceof ProxyDataSource)) {
 
             final ProxyFactory factory = new ProxyFactory(bean);
             factory.setProxyTargetClass(true);
-            factory.addAdvice(new ProxyDataSourceInterceptor((DataSource) bean));
+            factory.addAdvice(new ProxyDataSourceInterceptor(dataSource));
             return factory.getProxy();
         }
         return bean;

diff --git a/jpa/boot-jpa-locks/src/main/java/com/example/locks/entities/Movie.java b/jpa/boot-jpa-locks/src/main/java/com/example/locks/entities/Movie.java
@@ -28,7 +28,7 @@ public class Movie {
     private BigDecimal budget;
 
     @OneToMany(mappedBy = "movie", cascade = CascadeType.ALL)
-    private List<Review> reviews;
+    private List<Reviews> reviews;
 
     @ManyToOne(cascade = CascadeType.ALL)
     @JoinColumn(name = "director_id")
@@ -66,7 +66,7 @@ public Movie setBudget(BigDecimal budget) {
         return this;
     }
 
-    public Movie setReviews(List<Review> reviews) {
+    public Movie setReviews(List<Reviews> reviews) {
         this.reviews = reviews;
         return this;
     }

diff --git a/...va/com/example/locks/entities/Review.java → ...a/com/example/locks/entities/Reviews.java b/...va/com/example/locks/entities/Review.java → ...a/com/example/locks/entities/Reviews.java
@@ -10,7 +10,7 @@
 @Setter
 @NoArgsConstructor
 @Table(name = "reviews")
-public class Review {
+public class Reviews {
 
     @Id
     @GeneratedValue(strategy = GenerationType.SEQUENCE)

diff --git a/jpa/boot-jpa-locks/src/main/java/com/example/locks/mapper/JpaLocksMapper.java b/jpa/boot-jpa-locks/src/main/java/com/example/locks/mapper/JpaLocksMapper.java
@@ -3,13 +3,12 @@
 import com.example.locks.entities.Actor;
 import com.example.locks.entities.Genre;
 import com.example.locks.entities.Movie;
-import com.example.locks.entities.Review;
+import com.example.locks.entities.Reviews;
 import com.example.locks.model.request.ActorRequest;
 import com.example.locks.model.request.MovieRequest;
 import com.example.locks.model.response.ActorResponse;
 import com.example.locks.model.response.MovieResponse;
 import java.util.List;
-import java.util.stream.Collectors;
 import org.mapstruct.Mapper;
 import org.mapstruct.Mapping;
 import org.mapstruct.MappingTarget;
@@ -23,7 +22,7 @@ public interface JpaLocksMapper {
     default Movie movieRequestToMovieEntity(MovieRequest movieRequest) {
         var movie = movieRequestToMovie(movieRequest);
         for (Actor a : movie.getActors()) a.setMovies(List.of(movie));
-        for (Review r : movie.getReviews()) r.setMovie(movie);
+        for (Reviews r : movie.getReviews()) r.setMovie(movie);
         for (Genre g : movie.getGenres()) g.setMovies(List.of(movie));
         return movie;
     }
@@ -33,7 +32,7 @@ default Movie movieRequestToMovieEntity(MovieRequest movieRequest) {
     MovieResponse movieToMovieResponse(Movie movie);
 
     default List<MovieResponse> moviesListToMovieResponseList(List<Movie> moviesList) {
-        return moviesList.stream().map(this::movieToMovieResponse).collect(Collectors.toList());
+        return moviesList.stream().map(this::movieToMovieResponse).toList();
     }
 
     ActorResponse actorToActorResponse(Actor actor);

diff --git a/jpa/boot-jpa-locks/src/main/java/com/example/locks/repositories/ReviewRepository.java b/jpa/boot-jpa-locks/src/main/java/com/example/locks/repositories/ReviewRepository.java
diff --git a/jpa/boot-jpa-locks/src/main/java/com/example/locks/repositories/ReviewsRepository.java b/jpa/boot-jpa-locks/src/main/java/com/example/locks/repositories/ReviewsRepository.java
@@ -0,0 +1,6 @@
+package com.example.locks.repositories;
+
+import com.example.locks.entities.Reviews;
+import org.springframework.data.jpa.repository.JpaRepository;
+
+public interface ReviewsRepository extends JpaRepository<Reviews, Long> {}
diff --git a/jpa/boot-jpa-locks/src/test/java/com/example/locks/entities/ActorEntityTest.java b/jpa/boot-jpa-locks/src/test/java/com/example/locks/entities/ActorEntityTest.java
@@ -16,7 +16,7 @@
 
 @DataJpaTest
 @Disabled
-public class ActorEntityTest {
+class ActorEntityTest {
 
     @Autowired
     private TestEntityManager entityManager;
@@ -26,7 +26,7 @@ public class ActorEntityTest {
 
     @Test
     @Transactional
-    public void testPessimisticWriteLock() {
+    void testPessimisticWriteLock() {
         Actor entityToSave = new Actor();
         entityToSave.setActorName("TestEntityName");
 

diff --git a/jpa/boot-jpa-locks/src/test/java/com/example/locks/web/controllers/MovieControllerIT.java b/jpa/boot-jpa-locks/src/test/java/com/example/locks/web/controllers/MovieControllerIT.java
@@ -22,7 +22,7 @@
 import com.example.locks.model.request.MovieRequest;
 import com.example.locks.model.request.ReviewRequest;
 import com.example.locks.repositories.MovieRepository;
-import com.example.locks.repositories.ReviewRepository;
+import com.example.locks.repositories.ReviewsRepository;
 import java.math.BigDecimal;
 import java.time.LocalDate;
 import java.util.ArrayList;
@@ -39,7 +39,7 @@ class MovieControllerIT extends AbstractIntegrationTest {
     private MovieRepository movieRepository;
 
     @Autowired
-    private ReviewRepository reviewRepository;
+    private ReviewsRepository reviewRepository;
 
     private List<Movie> movieList = null;