feat: fix issue with mapping

rajadilipkolli · Nov 11, 2023 · a085764 · a085764
1 parent ef13cc6
commit a085764
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 48 deletions.
diff --git a/.github/workflows/spring-boot-graphql-querydsl.yml b/.github/workflows/spring-boot-graphql-querydsl.yml
diff --git a/...l/boot-graphql-querydsl/src/main/java/com/example/graphql/querydsl/mapper/PostMapper.java b/...l/boot-graphql-querydsl/src/main/java/com/example/graphql/querydsl/mapper/PostMapper.java
@@ -7,13 +7,11 @@
 import com.example.graphql.querydsl.model.response.PostResponse;
 import com.example.graphql.querydsl.model.response.TagResponse;
 import java.util.List;
-import org.mapstruct.DecoratedWith;
 import org.mapstruct.Mapper;
 import org.mapstruct.Mapping;
 import org.mapstruct.MappingTarget;
 
-@Mapper
-@DecoratedWith(PostMapperDecorator.class)
+@Mapper(uses = PostMapperHelper.class)
 public interface PostMapper {
 
     @Mapping(target = "tags", ignore = true)
@@ -39,5 +37,6 @@ public interface PostMapper {
 
     List<PostResponse> toResponseList(List<Post> postList);
 
+    @Mapping(target = "tags", ignore = true)
     Post setTags(List<TagRequest> tagRequests, Post post);
 }
diff --git a/.../querydsl/mapper/PostMapperDecorator.java → ...hql/querydsl/mapper/PostMapperHelper.java b/.../querydsl/mapper/PostMapperDecorator.java → ...hql/querydsl/mapper/PostMapperHelper.java
@@ -22,7 +22,7 @@
 import org.springframework.util.CollectionUtils;
 
 @Mapper
-public abstract class PostMapperDecorator implements PostMapper {
+public abstract class PostMapperHelper {
 
     @Autowired
     private TagRepository tagRepository;
@@ -38,11 +38,11 @@ void setAfterMappingToPost(CreatePostRequest createPostRequest, @MappingTarget P
                     new PostComment().setReview(postCommentRequest.review()).setCreatedOn(LocalDateTime.now())));
         }
 
-        setTags(createPostRequest.tags(), post);
+        updateTagsToPost(createPostRequest.tags(), post);
     }
 
-    @Override
-    public Post setTags(List<TagRequest> tagRequests, Post post) {
+    @AfterMapping
+    void updateTagsToPost(List<TagRequest> tagRequests, @MappingTarget Post post) {
         if (!CollectionUtils.isEmpty(tagRequests)) {
             tagRequests.forEach(tagRequest -> {
                 Predicate predicate = QTag.tag.name.equalsIgnoreCase(tagRequest.name());
@@ -56,6 +56,5 @@ public Post setTags(List<TagRequest> tagRequests, Post post) {
                 }
             });
         }
-        return post;
     }
 }
diff --git a/...phql-querydsl/src/main/java/com/example/graphql/querydsl/repositories/PostRepository.java b/...phql-querydsl/src/main/java/com/example/graphql/querydsl/repositories/PostRepository.java
@@ -26,6 +26,6 @@ default void customize(QuerydslBindings bindings, QPost root) {
             "select o from Post o left join fetch o.details pd left join fetch o.comments where pd.createdBy = :createdBy")
     List<Post> findByDetails_CreatedByEqualsIgnoreCase(@Param("createdBy") String createdBy);
 
-    @Query("select p from Post p left join fetch p.tags where p in :posts")
+    @Query("select p from Post p left join fetch p.tags where p in :posts ORDER BY p.id")
     List<Post> findAllPostsWithTags(@Param("posts") List<Post> posts);
 }