feat: fix sonar issue

rajadilipkolli · Oct 25, 2023 · 4dcfadc · 4dcfadc
1 parent 8125f36
commit 4dcfadc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/boot-mongodb-elasticsearch/src/test/java/com/example/mongoes/TestApplication.java b/boot-mongodb-elasticsearch/src/test/java/com/example/mongoes/TestApplication.java
@@ -17,7 +17,7 @@ public class TestApplication {
     @Bean
     @RestartScope
     ElasticsearchContainer elasticsearchContainer() {
-        return new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch:8.10.3")
+        return new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch:8.10.4")
                 .withEnv(Map.of("xpack.security.enabled", "false"));
     }
 

diff --git a/...a/com/example/mongoes/elasticsearch/repository/RestaurantESRepositoryIntegrationTest.java b/...a/com/example/mongoes/elasticsearch/repository/RestaurantESRepositoryIntegrationTest.java
@@ -1,15 +1,16 @@
 package com.example.mongoes.elasticsearch.repository;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.awaitility.Awaitility.await;
 
 import com.example.mongoes.common.AbstractIntegrationTest;
 import com.example.mongoes.document.Address;
 import com.example.mongoes.document.Grades;
 import com.example.mongoes.document.Restaurant;
+import java.time.Duration;
 import java.time.LocalDateTime;
 import java.util.List;
 import java.util.Map;
-import java.util.concurrent.TimeUnit;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
@@ -36,7 +37,7 @@ class RestaurantESRepositoryIntegrationTest extends AbstractIntegrationTest {
     @Autowired private RestaurantESRepository restaurantESRepository;
 
     @BeforeAll
-    void setUpData() throws InterruptedException {
+    void setUpData() {
         Restaurant restaurant = new Restaurant();
         restaurant.setRestaurantId(2L);
         restaurant.setName(RESTAURANT_NAME);
@@ -61,7 +62,10 @@ void setUpData() throws InterruptedException {
                 .log("saving restaurant")
                 .subscribe();
 
-        TimeUnit.SECONDS.sleep(5);
+        await().atMost(Duration.ofSeconds(10))
+                .pollInterval(Duration.ofSeconds(1))
+                .untilAsserted(
+                        () -> assertThat(this.restaurantESRepository.count().block()).isEqualTo(2));
     }
 
     @Test