Skip to content

Commit

Permalink
feat : implement code review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rajadilipkolli committed Nov 1, 2024
1 parent 07565ad commit 0730b99
Show file tree
Hide file tree
Showing 55 changed files with 708 additions and 547 deletions.
4 changes: 2 additions & 2 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"component: keyset-pagination-data-jpa":
- changed-files:
- any-glob-to-any-file:
- jpa/keyset-pagination/boot-data-window-paginiation/**/*
- jpa/keyset-pagination/boot-data-window-pagination/**/*
"component: jpa-multitenancy":
- changed-files:
- any-glob-to-any-file:
Expand Down Expand Up @@ -148,7 +148,7 @@
- jpa/boot-data-jpa-locks/pom.xml
- jpa/boot-read-replica-postgresql/pom.xml
- jpa/keyset-pagination/blaze-persistence/pom.xml
- jpa/keyset-pagination/boot-data-window-paginiation/pom.xml
- jpa/keyset-pagination/boot-data-window-pagination/pom.xml
- jpa/multitenancy/multitenancy-db/pom.xml
- jpa/multitenancy/multidatasource-multitenancy/pom.xml
- jpa/multitenancy/partition/pom.xml
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/boot-jpa-keyset-pagination-data-jpa.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: boot-data-keyset-pagination
name: boot-jpa-keyset-pagination-data-jpa

on:
push:
paths:
- "jpa/keyset-pagination/boot-data-window-paginiation/**"
- "jpa/keyset-pagination/boot-data-window-pagination/**"
branches: [main]
pull_request:
paths:
- "jpa/keyset-pagination/boot-data-window-paginiation/**"
- "jpa/keyset-pagination/boot-data-window-pagination/**"
types:
- opened
- synchronize
Expand All @@ -19,7 +19,7 @@ jobs:
runs-on: ubuntu-latest
defaults:
run:
working-directory: "jpa/keyset-pagination/boot-data-window-paginiation"
working-directory: "jpa/keyset-pagination/boot-data-window-pagination"
steps:
- uses: actions/checkout@v4
with:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,23 @@
version: '3.8'
services:

boot-data-window-paginiation:
build: ..
ports:
- "18080:8080"
- "18787:8787"
restart: always
depends_on:
- postgresqldb
environment:
- SPRING_PROFILES_ACTIVE=docker
- SPRING_DATASOURCE_DRIVER_CLASS_NAME=org.postgresql.Driver
- SPRING_DATASOURCE_URL=jdbc:postgresql://postgresqldb:5432/appdb
- SPRING_DATASOURCE_USERNAME=appuser
- SPRING_DATASOURCE_PASSWORD=secret
version: '3.8'
services:

boot-data-window-paginiation:
build: ..
ports:
- "18080:8080"
- "18787:8787"
restart: unless-stopped
healthcheck:
test: ["CMD", "curl", "-f", "http://localhost:8080/actuator/health"]
interval: 30s
timeout: 10s
retries: 3
start_period: 40s
depends_on:
- postgresqldb
environment:
- SPRING_PROFILES_ACTIVE=docker
- SPRING_DATASOURCE_DRIVER_CLASS_NAME=org.postgresql.Driver
- SPRING_DATASOURCE_URL=jdbc:postgresql://postgresqldb:5432/appdb
- SPRING_DATASOURCE_USERNAME=appuser
- SPRING_DATASOURCE_PASSWORD=secret
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
version: '3.8'
services:

postgresqldb:
image: postgres:16.3-alpine
environment:
- POSTGRES_USER=appuser
- POSTGRES_PASSWORD=secret
- POSTGRES_DB=appdb
ports:
- "5432:5432"

version: '3.8'
services:

postgresqldb:
image: postgres:16.3-alpine
environment:
- POSTGRES_USER=appuser
- POSTGRES_PASSWORD=secret
- POSTGRES_DB=appdb
ports:
- "5432:5432"

Loading

0 comments on commit 0730b99

Please sign in to comment.