feat : process events parallelly #650
Conversation
|
Warning Rate Limit Exceeded@rajadilipkolli has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 17 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe update enhances the AWS Kinesis project by introducing virtual threads for better scalability, refining the processing logic in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
aws-kinesis-project/consumer/src/main/resources/logback-spring.xmlis excluded by:!**/*.xml
Files selected for processing (3)
- aws-kinesis-project/consumer/README.md (1 hunks)
- aws-kinesis-project/consumer/src/main/java/com/learning/aws/spring/consumer/IpConsumer.java (2 hunks)
- aws-kinesis-project/consumer/src/main/resources/application.properties (2 hunks)
Additional comments: 3
aws-kinesis-project/consumer/README.md (1)
- 16-16: The addition of
DEFAULT_BOUNDED_ELASTIC_ON_VIRTUAL_THREADS=trueis well-documented. However, it would be beneficial to provide a brief explanation or link to documentation on how virtual threads enhance the processing capabilities. This would help users understand the significance of this configuration change.aws-kinesis-project/consumer/src/main/resources/application.properties (2)
- 5-5: The configuration
spring.threads.virtual.enabled=truealigns with the PR's objective to utilize virtual threads. Ensure that all components of the application are compatible with this setting to avoid unexpected behavior.- 38-38: Setting
spring.reactor.schedulers.defaultBoundedElasticOnVirtualThreads=trueis a significant change that leverages virtual threads for Reactor's bounded elastic scheduler. It's crucial to monitor the application's performance and thread utilization post-deployment to ensure that this change leads to the expected improvements without causing resource exhaustion.
aws-kinesis-project/consumer/src/main/java/com/learning/aws/spring/consumer/IpConsumer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- aws-kinesis-project/consumer/src/test/resources/application-test.properties (1 hunks)
Additional comments: 1
aws-kinesis-project/consumer/src/test/resources/application-test.properties (1)
- 4-4: The configuration
spring.cloud.stream.bindings.producerSupplier-out-0.producer.header-mode=nonesets the producer header mode tonone. Ensure this aligns with the testing requirements, especially if any tests depend on message headers.
|
Summary by CodeRabbit