fix : add correct Integrationtest

rajadilipkolli · Nov 6, 2023 · 1a4ce93 · 1a4ce93
1 parent 47474a7
commit 1a4ce93
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/aws-ses-project/src/test/java/com/example/awsspring/common/LocalStackConfig.java b/aws-ses-project/src/test/java/com/example/awsspring/common/LocalStackConfig.java
@@ -1,7 +1,5 @@
 package com.example.awsspring.common;
 
-import static org.testcontainers.containers.localstack.LocalStackContainer.Service.SES;
-
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.test.context.DynamicPropertyRegistry;
 import org.springframework.test.context.DynamicPropertySource;
@@ -31,6 +29,6 @@ static void setDynamicProperties(DynamicPropertyRegistry dynamicPropertyRegistry
         dynamicPropertyRegistry.add(
                 "spring.cloud.aws.region.static", localStackContainer::getRegion);
         dynamicPropertyRegistry.add(
-                "spring.cloud.aws.endpoint", () -> localStackContainer.getEndpointOverride(SES));
+                "spring.cloud.aws.endpoint", () -> localStackContainer.getEndpoint().toString());
     }
 }
diff --git a/...oject/src/test/java/com/example/awsspring/service/NotificationServiceIntegrationTest.java b/...oject/src/test/java/com/example/awsspring/service/NotificationServiceIntegrationTest.java
@@ -1,8 +1,9 @@
 package com.example.awsspring.service;
 
+import static org.awaitility.Awaitility.await;
+
 import com.example.awsspring.common.AbstractIntegrationTest;
 import java.time.Duration;
-import org.awaitility.Awaitility;
 import org.hamcrest.Matchers;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -20,8 +21,7 @@ void testSendMail() {
         simpleMailMessage.setSubject("test subject");
         simpleMailMessage.setText("test text");
 
-        Awaitility.await()
-                .atLeast(Duration.ofSeconds(1))
+        await().atLeast(Duration.ofSeconds(1))
                 .atMost(Duration.ofSeconds(60))
                 .with()
                 .pollInterval(Duration.ofSeconds(1))
@@ -32,12 +32,12 @@ void testSendMail() {
 
     @Test
     void testSendMailWithAttachments() {
-        SimpleMailMessage simpleMailMessage = new SimpleMailMessage();
-        simpleMailMessage.setFrom("[email protected]");
-        simpleMailMessage.setTo("[email protected]");
-        simpleMailMessage.setSubject("test subject");
-        simpleMailMessage.setText("test text");
-
-        notificationService.sendMailMessage(simpleMailMessage);
+        await().atLeast(Duration.ofSeconds(1))
+                .atMost(Duration.ofSeconds(60))
+                .with()
+                .pollInterval(Duration.ofSeconds(1))
+                .until(
+                        () -> notificationService.sendMailMessageWithAttachments(),
+                        Matchers.equalTo("sent"));
     }
 }