Implement board.left event to sync user list when someone leaves the …

…board
raimohanska · Jan 24, 2024 · 74125fe · 74125fe
1 parent b930c66
commit 74125fe
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/backend/src/websocket-sessions.ts b/backend/src/websocket-sessions.ts
@@ -111,6 +111,7 @@ export function endSession(socket: WsWrapper) {
  const boardState = maybeGetBoard(session.boardSession.boardId)
  if (boardState) {
  boardState.sessions = boardState.sessions.filter((s) => s.sessionId !== sessionId)
+ broadcastBoardEvent({ action: "board.left", boardId: boardState.board.id, sessionId })
  } else {
  console.warn(`Board state not found when ending session: ${session.boardSession.boardId}`)
  }

diff --git a/common/src/domain.ts b/common/src/domain.ts
@@ -236,6 +236,7 @@ export type BoardStateSyncEvent =
  | GotBoardLocks
  | CursorPositions
  | JoinedBoard
+ | LeftBoard
  | UserLoggedIn
  | AckJoinBoard
  | DeniedJoinBoard
@@ -326,6 +327,7 @@ export type RecentBoardsFromServer = { action: "user.boards"; email: string; boa
 export type Ack = { action: "ack"; ackId: string; serials: Record<Id, Serial> }
 export type ActionApplyFailed = { action: "board.action.apply.failed" }
 export type JoinedBoard = { action: "board.joined"; boardId: Id } & UserSessionInfo
+export type LeftBoard = { action: "board.left"; boardId: Id; sessionId: Id }
 export type UserInfoUpdate = { action: "userinfo.set" } & UserSessionInfo
 export type InitBoardNew = { action: "board.init"; board: Board; accessLevel: AccessLevel }
 export type InitBoardDiff = {

diff --git a/frontend/src/store/board-store.ts b/frontend/src/store/board-store.ts
@@ -200,6 +200,8 @@ export function BoardStore(
  }
  } else if (event.action === "board.joined") {
  return { ...state, users: state.users.concat(event) }
+ } else if (event.action === "board.left") {
+ return { ...state, users: state.users.filter((u) => u.sessionId !== event.sessionId) }
  } else if (event.action === "board.locks") {
  return { ...state, locks: event.locks }
  } else if (event.action === "ack") {