forked from spree/spree_gateway
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 0 stable braintree v.zero #1
Open
acreilly
wants to merge
40
commits into
master
Choose a base branch
from
3-0-stable-braintree-v.zero
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The orders resource in spree excludes index, new, create and destroy but the previous code was re-adding these back while trying to define nested resources. This patch fixes the unnecessary routes from being added by specifying that no order resource routes should be added. fixes spree#186
…information if present when on purchase
…eway to match setting for test server fixing Spree::Gateway::AuthorizeNetCim to set :test preference to reflect server 'test' or 'live' Adds :server preference to Gateway::AuthorizeNetCim (defaults to 'test') and raises exceptions if store does not have preference :server set to either of 'live' or 'test' fixes spree#195
…ant changed awhile back.
…submit handlers can be run, e.g. Spree.disableSaveOnClick() fixes spree#199
Fix for capture method on Authorize.net CIM adapter Refactored how parameters are passed to Auth.net. Made sure test requests are never made because they are pointless. Fix to try to not update a profile that doesn't exist. Added cancel to Authorize.net CIM Added cancel method to normal Authorize.net. fixes spree#203
Only receives a single argument fixes spree#205
…ayment method env being dropped. Fixes spree#206
Fix to nil for gateway_options Fixes spree#208 Conflicts: app/models/spree/gateway/authorize_net_cim.rb
…r appended with #. For AuthorizeNetGateway the refund action attempts to lookup card_number from splitting authorization: https://github.com/Shopify/active_merchant/blob/master/lib/active_merchant/billing/gateways/authorize_net.rb#L107 It attempts to split response_code#card_number: https://github.com/Shopify/active_merchant/blob/master/lib/active_merchant/billing/gateways/authorize_net.rb#L478 However #card_number is not appended to response_code so we must set it as a fallback option: https://github.com/Shopify/active_merchant/blob/master/lib/active_merchant/billing/gateways/authorize_net.rb#L114 Fixes spree/spree#4813
Update specfile to depend on spree_core 3.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.