Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete ready_executions only when they've been claimed #31

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Delete ready_executions only when they've been claimed #31

merged 3 commits into from
Oct 30, 2023

Commits on Oct 30, 2023

  1. Delete ready_executions only when they've been claimed 

    If we try to claim a set of job IDs, creating claimed executions for them,
but for some reason, we fail to do that for some of them, in a way that the
failure is ignored (eg. on a duplicate key conflict that gets ignored with
Rails's `insert_all`), we'd be deleting the ready execution for these, even
if they weren't claimed at all, leaving the job in limbo. This change simplifies
a bit the claiming code and ensures only those jobs that have been claimed are
indeed deleted.
    @rosa
    rosa committed Oct 30, 2023
    1 Configuration menu
    Copy the full SHA
    5787092 View commit details
    Browse the repository at this point in the history

  2. Add NOT NULL constraints to all job_id columns

    @rosa
    rosa committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    722c99b View commit details
    Browse the repository at this point in the history

  3. Tweak waiting times in tests to prevent timeouts locally

    @rosa
    rosa committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    57bad40 View commit details
    Browse the repository at this point in the history