Rename concurrency limit spec to limits_concurrency to: limit ...

Thanks to @jorgemanrubia for the suggestion!
rails · Nov 20, 2023 · 6051c58 · 6051c58
1 parent 9b99846
commit 6051c58
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/lib/active_job/concurrency_controls.rb b/lib/active_job/concurrency_controls.rb
@@ -14,8 +14,8 @@ module ConcurrencyControls
  end
 
  class_methods do
- def restrict_concurrency_with(limit: 1, key: DEFAULT_CONCURRENCY_KEY, duration: SolidQueue.default_concurrency_control_period)
- self.concurrency_limit = limit
+ def limits_concurrency(to: 1, key: DEFAULT_CONCURRENCY_KEY, duration: SolidQueue.default_concurrency_control_period)
+ self.concurrency_limit = to
  self.concurrency_key = key
  self.concurrency_duration = duration
  end

diff --git a/test/dummy/app/jobs/sequential_update_result_job.rb b/test/dummy/app/jobs/sequential_update_result_job.rb
@@ -1,3 +1,3 @@
 class SequentialUpdateResultJob < UpdateResultJob
- restrict_concurrency_with limit: 1, key: ->(job_result, **) { job_result }
+ limits_concurrency key: ->(job_result, **) { job_result }
 end
diff --git a/test/dummy/app/jobs/throttled_update_result_job.rb b/test/dummy/app/jobs/throttled_update_result_job.rb
@@ -1,3 +1,3 @@
 class ThrottledUpdateResultJob < UpdateResultJob
- restrict_concurrency_with limit: 3, key: ->(job_result, **) { job_result }
+ limits_concurrency to: 3, key: ->(job_result, **) { job_result }
 end
diff --git a/test/models/solid_queue/job_test.rb b/test/models/solid_queue/job_test.rb
@@ -2,7 +2,7 @@
 
 class SolidQueue::JobTest < ActiveSupport::TestCase
  class NonOverlappingJob < ApplicationJob
- restrict_concurrency_with limit: 1, key: ->(job_result, **) { job_result }
+ limits_concurrency key: ->(job_result, **) { job_result }
 
  def perform(job_result)
  end