Fix guide redirects #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v4.2 and v5.0 guides are the only guides which link to `constant_autoloading_and_reloading.html`. However, visiting that path in either version currently redirects to the stable version of `autoloading_and_reloading_constants.html`, which is a Zeitwerk guide as of Rails 6.0. This commit preserves the guide version when redirecting.
Follow-up to 6eafc6e. `migrations.html` was renamed to `active_record_migrations.html` in Rails 4.2, but the v4.2 and v5.0 guides link to the old path. Visiting `migrations.html` in v4.2 or later, including stable, currently redirects to the edge version of `active_record_migrations.html`, which may go unnoticed and cause confusion. This commit ensures `migrations.html` redirects to the appropriate `active_record_migrations.html` for the v4.2 and later guides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split into two commits, which solve the following problems:
The v4.2 and v5.0 guides are the only guides which link to
constant_autoloading_and_reloading.html. However, visiting that path in either version currently redirects to the stable version ofautoloading_and_reloading_constants.html, which is a Zeitwerk guide as of Rails 6.0.migrations.htmlwas renamed toactive_record_migrations.htmlin Rails 4.2, but the v4.2 and v5.0 guides link to the old path. Visitingmigrations.htmlin v4.2 or later, including stable, currently redirects to the edge version ofactive_record_migrations.html, which may go unnoticed and cause confusion.rails-docs-serverdependencies installed at the moment, and so have not tested the conf itself. I am hoping some very generous person will double-check these changes. 🙏