Mirror services execution is now threaded (with promises)

rails · Jul 8, 2017 · a5e4715 · a5e4715
1 parent 44aab4d
commit a5e4715
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/active_storage/service/mirror_service.rb b/lib/active_storage/service/mirror_service.rb
@@ -1,4 +1,5 @@
 require "active_support/core_ext/module/delegation"
+require "concurrent"
 
 class ActiveStorage::Service::MirrorService < ActiveStorage::Service
   attr_reader :services
@@ -26,9 +27,8 @@ def primary_service
     end
 
     def perform_across_services(method, *args)
-      # FIXME: Convert to be threaded
       services.collect do |service|
-        service.public_send method, *args
-      end
+        Concurrent::Promise.execute { service.public_send method, *args }
+      end.map(&:value)
     end
 end