fix rare duplicated data buffer entry #62
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In bad network connection, agentlace's
TrainerClient
might not track the latest inserted batch data correctly, which resulted in duplicated data entry from theactor node
tolearner node
. This will degrade the performance of online learning, since the sequential nature of the data is no longer obeyed.Fix
[Highly Recommended]
The straightforward fix is to bump up the version of
agentlace
(or pull the latestmain
). For more details, checkout the PR: youliangtan/agentlace#11Additional
experimental_pipeline_urlexperimental_pipeline_port
method is introduced to speed up the method.Related to youliangtan/agentlace#13
QueuedDataStore
to reduce unnecessary memory consumption on the actor node