Skip to content

Commit

Permalink
drpc: add missing logger
Browse files Browse the repository at this point in the history
If we don't use the passed logger, we don't get the rid in the logs.

Signed-off-by: Raghavendra Talur <[email protected]>
  • Loading branch information
raghavendra-talur committed Dec 17, 2024
1 parent 4563fb3 commit 10c61cf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/controller/drplacementcontrol_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -1271,7 +1271,7 @@ func (r *DRPlacementControlReconciler) updateDRPCStatus(
) error {
log.Info("Updating DRPC status")

r.updateResourceCondition(ctx, drpc, userPlacement)
r.updateResourceCondition(ctx, drpc, userPlacement, log)

// set metrics if DRPC is not being deleted and if finalizer exists
if !isBeingDeleted(drpc, userPlacement) && controllerutil.ContainsFinalizer(drpc, DRPCFinalizer) {
Expand Down Expand Up @@ -1313,7 +1313,7 @@ func (r *DRPlacementControlReconciler) updateDRPCStatus(
//
//nolint:funlen
func (r *DRPlacementControlReconciler) updateResourceCondition(
ctx context.Context, drpc *rmn.DRPlacementControl, userPlacement client.Object,
ctx context.Context, drpc *rmn.DRPlacementControl, userPlacement client.Object, log logr.Logger,

Check failure on line 1316 in internal/controller/drplacementcontrol_controller.go

View workflow job for this annotation

GitHub Actions / Golangci Lint (.)

`(*DRPlacementControlReconciler).updateResourceCondition` - `log` is unused (unparam)
) {
vrgNamespace, err := selectVRGNamespace(r.Client, r.Log, drpc, userPlacement)
if err != nil {
Expand Down

0 comments on commit 10c61cf

Please sign in to comment.