Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Validation Logic for TANF Active Case Items 27, 29, 26AIII, and 32D #3292

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tdrs-backend/tdpservice/parsers/schema_defs/ssp/m2.py
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@
startIndex=48,
endIndex=49,
required=False,
validators=[category2.isGreaterThan(0)]
validators=[category2.isGreaterThan(0, inclusive=True)]
),
Field(
item="32E",
Expand Down
6 changes: 3 additions & 3 deletions tdrs-backend/tdpservice/parsers/schema_defs/tanf/t1.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
),
category3.ifThenAlso(
condition_field_name="SANC_REDUCTION_AMT",
condition_function=category3.isGreaterThan(0),
condition_function=category3.isGreaterThan(0, inclusive=True),
result_field_name="FAMILY_SANC_ADULT",
result_function=category3.isOneOf((1, 2)),
),
Expand Down Expand Up @@ -635,7 +635,7 @@
endIndex=114,
required=False,
validators=[
category2.isOneOf(["9", " "]),
category2.isOneOf(["9", "0", " "]),
category2.isAlphaNumeric(),
],
),
Expand All @@ -658,7 +658,7 @@
endIndex=117,
required=False,
validators=[
category2.isOneOf([1, 2]),
category2.isOneOf([0, 1, 2]),
],
),
Field(
Expand Down
2 changes: 1 addition & 1 deletion tdrs-backend/tdpservice/parsers/test/test_parse.py
Original file line number Diff line number Diff line change
Expand Up @@ -950,7 +950,7 @@ def test_parse_tanf_section1_blanks_file(tanf_section1_file_with_blanks, dfs):

parser_errors = ParserError.objects.filter(file=tanf_section1_file_with_blanks)

assert parser_errors.count() == 22
assert parser_errors.count() == 23

# Should only be cat3 validator errors
for error in parser_errors:
Expand Down
Loading