fix(deps): support Rails 7 syntax #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafasoares
force-pushed
the
fix/deps/support-rails-7
branch
4 times, most recently
from
4aff3d2 to
fe6b69b
Compare
rafasoares
force-pushed
the
fix/deps/support-rails-7
branch
from
fe6b69b to
b537d80
Compare
|
Need to fix the flakiness with |
With the new version matrix setup, multiple uploads to the same artifact could fail, even with `overwrite: true`.
|
Code Climate has analyzed commit f9fbf42 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @guilhermearaujo for his help with #21.
However, I felt that a bigger refactor was necessary. Particularly with the specs, as they didn't come close to cover all the possible scenarios.
There are still some edge cases missing, but this makes me much more confident to do such updates in the future.
Note: I've deprecated both the class and instance
human_enum_valuemethods, as they seem to be redundant. I don't think they are used for anything, but please open a new issue if you're affected.Fixes #20