adds docs for resample, MODIS projection #730
Conversation
| # ? is this the right ProjString ?, do we need to shift lat, lon? | ||
| SINUSOIDAL_CRS = ProjString("+proj=sinu +lon_0=0 +x_0=0 +y_0=0 +a=6371007.181 +b=6371007.181 +units=m +no_defs") |
There was a problem hiding this comment.
Users will be wondering what the hell a ProjString is, we should explain that
There was a problem hiding this comment.
also @lazarusA why are you defining the ellipse here? That seems like a step too far. How about:
| # ? is this the right ProjString ?, do we need to shift lat, lon? | |
| SINUSOIDAL_CRS = ProjString("+proj=sinu +lon_0=0 +x_0=0 +y_0=0 +a=6371007.181 +b=6371007.181 +units=m +no_defs") | |
| SINUSOIDAL_CRS = ProjString("+proj=sinu +lon_0=0 +type=crs") |
There was a problem hiding this comment.
Those tiles come/are set with very specific numbers. I think I did some tests, and you not always get the same numbers. BTW, feel free to merge this into your PR, I will probably not finish this anytime soon.
| ras_epsg = resample(ras_sin; size=(1440,720), crs=EPSG(4326), method="sum") | ||
| ```` | ||
|
|
||
| and let's apply `shiftlocus` such that we can harmonize coordinates, which might be needed when building bigger datasets: |
There was a problem hiding this comment.
what does this do, what does it mean to harmonize coordinates?
There was a problem hiding this comment.
I usually need to match to other variables, which are in a specific Lon/lat range.
docs/src/.vitepress/config.mts
Outdated
| @@ -73,6 +74,7 @@ export default defineConfig({ | |||
| { text: 'Methods', | |||
| items: [ | |||
| { text: 'Overview', link: '/methods' }, | |||
| { text: 'resample', link: '/resample_proj'}, | |||
There was a problem hiding this comment.
This should be capitalized IMO, or we could call the page Reprojection (since that's what it does - resampling to me implies a simple down- or up-sampling without nonlinearity).
There was a problem hiding this comment.
maybe both? Reprojection and resample.
There was a problem hiding this comment.
| { text: 'resample', link: '/resample_proj'}, | |
| { text: 'Reprojection and resampling', link: '/resample_proj'}, |
|
|
Co-authored-by: Anshul Singhvi <[email protected]>
|
I'll write a dropdown about what CRS is that we can include here, new users can then click on it if they need to. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
==========================================
- Coverage 82.59% 82.36% -0.23%
==========================================
Files 60 62 +2
Lines 4510 4537 +27
==========================================
+ Hits 3725 3737 +12
- Misses 785 800 +15 ☔ View full report in Codecov by Sentry. |
docs/Project.toml
Outdated
| Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80" | ||
| RasterDataSources = "3cb90ccd-e1b6-4867-9617-4276c8b2ca36" | ||
| Rasters = "a3a2b9e3-a471-40c9-b274-f788e487c689" | ||
| Shapefile = "8e980c4a-a4fe-5da2-b3a7-4b4b0353a2f4" | ||
| YAXArrays = "c21b50f5-aa40-41ea-b809-c0f5e47bfa5c" |
|
Is this ready to merge? |
| and let's apply `shiftlocus` such that we can harmonize coordinates, which might be needed when building bigger datasets: | ||
|
|
||
| ````@example modis | ||
| locus_resampled = DimensionalData.shiftlocus(Center(), ras_epsg) |
There was a problem hiding this comment.
What happens if we delete these? would be nice to avoid
There was a problem hiding this comment.
mmm... yes, but then we don't show how to do it. Which is needed, or at least I needed it 😄 .
|
there some things that might help, like saying or referencing to what |
Ok. I'm adding this because the usual just happened. I needed to do this, and yes, good luck finding docs or examples 😄 . Well, here, a version. It might need a second pass.
@asinghvi17 it would be also nice to include also your use cases.