add possibility to specify crop dimensions

[maxfreu]

This adds the possibility to specify crop dimensions. Hope it looks ok :)

[rafaqz]

Lools good

[maxfreu]

This was a clear case of not seeing the forest for the trees :D I'll fix it!

[codecov-commenter]

Codecov Report

Merging #539 (9e87dbd) into main (ff90b8f) will increase coverage by 7.92%.
Report is 3 commits behind head on main.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   73.06%   80.98%   +7.92%     
==========================================
  Files          59       57       -2     
  Lines        4633     4107     -526     
==========================================
- Hits         3385     3326      -59     
+ Misses       1248      781     -467     

Files	Coverage Δ
src/Rasters.jl	100.00% <ø> (ø)
src/methods/crop_extend.jl	89.13% <100.00%> (-0.12%)	⬇️
src/methods/mask.jl	90.00% <100.00%> (+0.38%)	⬆️
src/plotrecipes.jl	83.17% <ø> (+9.91%)	⬆️
src/stack.jl	84.47% <100.00%> (+0.09%)	⬆️
ext/RastersMakieExt/plotrecipes.jl	0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[maxfreu]

I noticed that there are unused variables in the crop functions, so it's likely that they don't work as you intended:

Rasters.jl/src/methods/crop_extend.jl

Lines 98 to 100 in 88af714

	sampled = reduce(to; init=()) do acc, d
	lookup(d) isa AbstractSampled ? (acc..., d) : acc
	end

Rasters.jl/src/methods/crop_extend.jl

Line 104 in 88af714

ds = dims(x, map(key2dim, keys(to)))

[rafaqz]

Good catch, the second one ds is just no longer needed, thats in DD now.

In the first sampled should be used instead of to. It will mostly just stop bands or other Categorical lookups being used to crop. We probably dont test that.

(Feel free to clean up/fix those)

[maxfreu]

Actually, cropping forward ordered categorical int64 band dimensions worked. But I changed it nevertheless, as there probably will be problems with string values.

[rafaqz]

Yeah the idea was you basically never want to use crop for bands or categorical things, so passing in bands in the to template should be ignored