-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use BitArray for burning buffer #533
Conversation
This branch speeds things up considerably but for the large use case threaded=false is still much faster
|
Ok thats way lower allocation at least. Maybe the threads are running into each other somehow, there is a lock in there but mostly it can be avoided. I'll have to look into that. |
b422d28
to
73101f5
Compare
Codecov Report
@@ Coverage Diff @@
## main #533 +/- ##
==========================================
+ Coverage 73.06% 80.98% +7.92%
==========================================
Files 59 57 -2
Lines 4633 4108 -525
==========================================
- Hits 3385 3327 -58
+ Misses 1248 781 -467
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@alex-s-gardner you could try this branch on your huge array without
threaded=false
It should use 1/8th of the memory.