-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a function to calculate cell size #508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! So excited to have this method in Rasters, thanks for writing it up.
I made a few comments on style and naming, and some doc string changes (that you can just merge in in the interface if you want them)
The tests are failing because we forgot to pass through the function name in the extensions error method - we should pass in e.g. cellarea
as f
and use it in the MethodError
Thanks for your comments! The MethodError should work now. |
Codecov Report
@@ Coverage Diff @@
## main #508 +/- ##
==========================================
- Coverage 81.25% 80.43% -0.83%
==========================================
Files 49 50 +1
Lines 4135 4170 +35
==========================================
- Hits 3360 3354 -6
- Misses 775 816 +41
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks! FYI usually a PR is merged when all the comments are resolved one way or another, by clicking the "resolve conversation" button if you think its been addressed :) |
Just to confirm, this is the Haversine distance, i.e., area by great circle calculation, not area by true geodesic (a la Karney/Vincenty)? |
It uses Girard's theorem. So it doesn't use Haversine distance exactly, but it is an approximation for spheres. |
Closes #415