Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address extend #245

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Address extend #245

wants to merge 11 commits into from

Conversation

GhenadieVP
Copy link
Contributor

No description provided.

@Sajjon
Copy link
Contributor

Sajjon commented Oct 29, 2024

Did we get any performance boost btw?

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 87.77778% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.4%. Comparing base (4694350) to head (0056bdf).

Files with missing lines Patch % Lines
.../src/profile/v100/address/non_fungible_local_id.rs 81.8% 6 Missing ⚠️
...src/profile/v100/address/non_fungible_global_id.rs 82.3% 3 Missing ⚠️
...iffi/src/profile/v100/address/component_address.rs 80.0% 1 Missing ⚠️
...n-uniffi/src/profile/v100/address/vault_address.rs 80.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #245   +/-   ##
=====================================
  Coverage   84.4%   84.4%           
=====================================
  Files       1186    1186           
  Lines      20749   20693   -56     
  Branches      77      77           
=====================================
- Hits       17514   17478   -36     
+ Misses      3221    3201   -20     
  Partials      14      14           
Flag Coverage Δ
rust 80.8% <87.7%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...dress/AccessControllerAddress+Wrap+Functions.swift 100.0% <ø> (ø)
...ethods/Address/AccountAddress+Wrap+Functions.swift 100.0% <ø> (ø)
...hods/Address/ComponentAddress+Wrap+Functions.swift 100.0% <ø> (ø)
...thods/Address/IdentityAddress+Wrap+Functions.swift 100.0% <ø> (ø)
...Methods/Address/LockerAddress+Wrap+Functions.swift 100.0% <ø> (ø)
...ethods/Address/PackageAddress+Wrap+Functions.swift 100.0% <ø> (ø)
...s/Methods/Address/PoolAddress+Wrap+Functions.swift 100.0% <ø> (ø)
...thods/Address/ResourceAddress+Wrap+Functions.swift 100.0% <ø> (ø)
...hods/Address/ValidatorAddress+Wrap+Functions.swift 100.0% <ø> (ø)
.../Methods/Address/VaultAddress+Wrap+Functions.swift 100.0% <ø> (ø)
... and 26 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants