-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak/sbor types separator #2035
Merged
Merged
+19
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
…omplex types
dhedey
changed the base branch from
develop
to
tweak/further-cuttlefish-tests-and-neatenings
December 3, 2024 22:08
Docker tags |
Benchmark for 597b961Click to view benchmark
|
iamyulong
approved these changes
Dec 4, 2024
dhedey
changed the base branch from
tweak/further-cuttlefish-tests-and-neatenings
to
develop
January 13, 2025 13:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small change which I noticed when making some gnarly types which involved child types containing generic associated types with two values - which needs a comma. This clashed with the comma separator in the type, so I've changed it to a semicolon instead.
Testing
Existing tests pass.
Update Recommendations
While technically a breaking change, I really doubt anyone in the community uses this with two or more types, and if they do, they'll get a pretty obvious compiler error.