Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add Cuttlefish protocol version #1884

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

dhedey
Copy link
Contributor

@dhedey dhedey commented Aug 21, 2024

Summary

Adds the Cuttlefish protocol version, and associated generated files.

Also fixes the metering tests; and updates the metering receipts for bottlenose (NOTE: The bottlenose metering hasn't actually changed since launch -- the receipts were just not properly asserted; so the metering had been updated since the receipts were generated, and hadn't been regenerated since bottlenose launch).

Copy link

Phylum Report Link

Copy link

github-actions bot commented Aug 21, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:8aaad9a238

Copy link

github-actions bot commented Aug 21, 2024

Benchmark for 8aaad9a

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 63.0±0.15ms 63.2±0.14ms +0.32%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.6±0.00ms 19.3±0.00ms -1.53%
costing::decode_encoded_i8_array_to_manifest_value 41.2±0.07ms 41.5±0.06ms +0.73%
costing::decode_encoded_tuple_array_to_manifest_raw_value 63.3±0.11ms 63.1±0.08ms -0.32%
costing::decode_encoded_tuple_array_to_manifest_value 118.8±1.24ms 98.9±0.15ms -16.75%
costing::decode_encoded_u8_array_to_manifest_raw_value 32.5±0.18µs 32.0±0.08µs -1.54%
costing::decode_encoded_u8_array_to_manifest_value 41.6±0.09ms 41.4±0.07ms -0.48%
costing::decode_rpd_to_manifest_raw_value 12.4±0.02µs 12.5±0.03µs +0.81%
costing::decode_rpd_to_manifest_value 11.0±0.02µs 11.1±0.02µs +0.91%
costing::deserialize_wasm 1240.3±3.81µs 1258.3±3.15µs +1.45%
costing::execute_transaction_creating_big_vec_substates 713.1±12.25ms 709.5±11.99ms -0.50%
costing::execute_transaction_reading_big_vec_substates 579.3±0.79ms 580.8±0.70ms +0.26%
costing::instantiate_flash_loan 964.4±773.86µs 1016.1±806.98µs +5.36%
costing::instantiate_radiswap 956.2±828.64µs 894.1±581.43µs -6.49%
costing::spin_loop 21.0±0.03ms 21.4±0.05ms +1.90%
costing::validate_sbor_payload 32.3±0.08µs 32.9±0.08µs +1.86%
costing::validate_sbor_payload_bytes 245.4±0.99ns 255.2±0.57ns +3.99%
costing::validate_secp256k1 76.7±0.07µs 76.8±0.08µs +0.13%
costing::validate_wasm 33.5±0.05ms 34.6±0.05ms +3.28%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 216.5±0.48ns 219.5±0.51ns +1.39%
decimal::add/wasmi-call-native 2.2±0.01µs 2.1±0.00µs -4.55%
decimal::div/0 187.1±0.45ns 186.7±0.14ns -0.21%
decimal::from_string/0 160.7±0.13ns 158.3±0.25ns -1.49%
decimal::mul/0 149.3±0.22ns 152.7±0.33ns +2.28%
decimal::mul/rust-native 147.7±0.29ns 147.5±0.13ns -0.14%
decimal::mul/wasmi 11.3±0.05µs 10.7±0.08µs -5.31%
decimal::mul/wasmi-call-native 2.3±0.01µs 2.2±0.00µs -4.35%
decimal::pow/0 698.1±0.74ns 693.9±0.61ns -0.60%
decimal::pow/rust-native 666.2±0.95ns 666.0±0.69ns -0.03%
decimal::pow/wasmi 53.8±0.23µs 51.9±0.51µs -3.53%
decimal::pow/wasmi-call-native 2.4±0.01µs 2.4±0.00µs 0.00%
decimal::root/0 7.9±0.01µs 7.7±0.01µs -2.53%
decimal::sub/0 8.3±0.01ns 8.3±0.01ns 0.00%
decimal::to_string/0 444.7±2.51ns 443.4±0.73ns -0.29%
precise_decimal::add/0 9.0±0.02ns 8.9±0.04ns -1.11%
precise_decimal::add/rust-native 10.7±0.03ns 10.7±0.01ns 0.00%
precise_decimal::add/wasmi 259.2±1.23ns 261.6±0.69ns +0.93%
precise_decimal::add/wasmi-call-native 2.7±0.01µs 2.8±0.00µs +3.70%
precise_decimal::div/0 316.3±0.37ns 317.7±0.34ns +0.44%
precise_decimal::from_string/0 198.4±0.24ns 198.2±0.30ns -0.10%
precise_decimal::mul/0 362.8±0.91ns 363.7±0.45ns +0.25%
precise_decimal::mul/rust-native 319.4±0.27ns 319.7±0.58ns +0.09%
precise_decimal::mul/wasmi 31.4±0.12µs 31.0±0.19µs -1.27%
precise_decimal::mul/wasmi-call-native 3.1±0.01µs 3.1±0.00µs 0.00%
precise_decimal::pow/0 1917.0±0.86ns 1928.0±1.11ns +0.57%
precise_decimal::pow/rust-native 1533.9±2.26ns 1552.3±5.42ns +1.20%
precise_decimal::pow/wasmi 147.5±0.52µs 150.8±0.23µs +2.24%
precise_decimal::pow/wasmi-call-native 5.5±0.01µs 5.5±0.01µs 0.00%
precise_decimal::root/0 57.5±0.05µs 57.7±0.03µs +0.35%
precise_decimal::sub/0 9.2±0.15ns 8.8±0.02ns -4.35%
precise_decimal::to_string/0 701.5±2.07ns 702.8±1.08ns +0.19%
schema::validate_payload 379.8±0.81µs 379.2±0.31µs -0.16%
transaction::radiswap 5.2±0.02ms 5.2±0.05ms 0.00%
transaction::transfer 1926.6±6.44µs 1918.6±9.12µs -0.42%
transaction_processing::prepare 2.4±0.00ms 2.4±0.00ms 0.00%
transaction_processing::prepare_and_decompile 6.0±0.04ms 6.0±0.02ms 0.00%
transaction_processing::prepare_and_decompile_and_recompile 26.5±2.20ms 24.4±1.14ms -7.92%
transaction_validation::validate_manifest 42.9±0.14µs 42.9±0.06µs 0.00%
transaction_validation::verify_bls_2KB 1004.8±13.20µs 1067.5±19.43µs +6.24%
transaction_validation::verify_bls_32B 1024.1±25.48µs 1002.2±10.09µs -2.14%
transaction_validation::verify_ecdsa 74.7±0.20µs 74.6±0.06µs -0.13%
transaction_validation::verify_ed25519 54.6±0.09µs 54.9±0.08µs +0.55%

@dhedey dhedey merged commit e5d6be4 into tweak/protocol-update-builder-tweaks Aug 28, 2024
29 checks passed
@dhedey
Copy link
Contributor Author

dhedey commented Aug 28, 2024

Heads up - I merged this into the wrong branch, so these changes actually got merged into develop with #1885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants