Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/transaction threads #1872

Closed
wants to merge 33 commits into from
Closed

Conversation

talekhinezh
Copy link
Member

Summary

INSTRUCTIONS:
Add summary - one or two sentences explaining the purpose of this PR.

Details

INSTRUCTIONS:
Provide further details about the changes, or how they fit into the roadmap.
You can delete this section if it's not useful.

Testing

INSTRUCTIONS:
Further details about the tests you've added or manually performed.
You can delete this section if it's not useful.

Update Recommendations

INSTRUCTIONS:
This section is to provide recommendations to consumers of this repo about how they
should handle breaking changes, or integrate new features. The two key stakeholder
groups are dApp Developers and Internal Integrators, and there are separate sections
for each.

In order to allow us to compile aggregated update instructions across PRs, please tag the PR
with 0+ of the relevant labels:
* scrypto-lib - Any change to the scrypto library
* sbor - Any breaking change to SBOR encoding/decoding
* manifest - Any change to manifest display, compilation/decompilation
* transaction - Any change which affects the compiled manifest, or transaction semantics
* substate - Any change to substates, the state model, or what's stored in the DB
* native-blueprint-interface - Any change to the interface of native blueprints
* files-moved - Any change to where engine types have moved, which will require
  internal integrators to update their imports

If you have a breaking change which doesn't fix into a category above, then tag it with
the closest label, and discuss in slack/discord.

If your PR contains no breaking changes or new features or hasn't been tagged, this whole
section can be deleted.

For dApp Developers

INSTRUCTIONS:
Migration recommendations for a dApp developer to update their dApp/integrations
due to to the change/s in this PR.

These will be aggregated by the Developer Ecosystem team and included in the next Scrypto migration guide
(eg https://docs-babylon.radixdlt.com/main/scrypto/release_notes/migrating_from_0.7_to_0.8.html )

For Internal Integrators

INSTRUCTIONS:
Instructions to any internal integrations (eg Node, Toolkit, Gateway, Ledger App) for how the changes may affect
them and recommendations for how they should update to support this change.

Copy link

Phylum Report Link

Copy link

github-actions bot commented Aug 10, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:1a077e046a

Copy link

Benchmark for 1a077e0

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 67.4±4.51ms 66.6±4.46ms -1.19%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.6±0.00ms 19.6±0.01ms 0.00%
costing::decode_encoded_i8_array_to_manifest_value 42.7±0.16ms 41.6±0.13ms -2.58%
costing::decode_encoded_tuple_array_to_manifest_raw_value 63.2±0.09ms 63.2±0.11ms 0.00%
costing::decode_encoded_tuple_array_to_manifest_value 98.7±0.23ms 99.5±0.35ms +0.81%
costing::decode_encoded_u8_array_to_manifest_raw_value 25.4±0.07µs 25.5±0.15µs +0.39%
costing::decode_encoded_u8_array_to_manifest_value 42.7±0.12ms 41.8±0.18ms -2.11%
costing::decode_rpd_to_manifest_raw_value 12.3±0.03µs 12.5±0.05µs +1.63%
costing::decode_rpd_to_manifest_value 11.0±0.10µs 10.7±0.01µs -2.73%
costing::deserialize_wasm 1258.9±3.26µs 1264.3±2.14µs +0.43%
costing::execute_transaction_creating_big_vec_substates 715.1±15.45ms 736.7±16.52ms +3.02%
costing::execute_transaction_reading_big_vec_substates 593.0±3.83ms 604.3±5.59ms +1.91%
costing::instantiate_flash_loan 984.9±858.87µs 1114.4±1743.04µs +13.15%
costing::instantiate_radiswap 950.6±715.85µs 980.4±829.04µs +3.13%
costing::spin_loop 22.3±0.07ms 21.3±0.04ms -4.48%
costing::validate_sbor_payload 32.6±0.09µs 32.4±0.08µs -0.61%
costing::validate_sbor_payload_bytes 247.7±2.59ns 245.1±0.42ns -1.05%
costing::validate_secp256k1 76.7±0.08µs 76.8±0.82µs +0.13%
costing::validate_wasm 33.7±0.04ms 33.5±0.04ms -0.59%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.9±0.00ns 9.8±0.00ns -1.01%
decimal::add/wasmi 223.2±0.83ns 220.0±0.22ns -1.43%
decimal::add/wasmi-call-native 2.1±0.00µs 2.1±0.01µs 0.00%
decimal::div/0 187.2±0.35ns 187.5±0.06ns +0.16%
decimal::from_string/0 160.2±0.20ns 159.5±0.25ns -0.44%
decimal::mul/0 148.9±0.48ns 150.2±0.48ns +0.87%
decimal::mul/rust-native 146.4±0.11ns 143.9±0.17ns -1.71%
decimal::mul/wasmi 11.7±0.07µs 12.2±0.04µs +4.27%
decimal::mul/wasmi-call-native 2.3±0.00µs 2.2±0.00µs -4.35%
decimal::pow/0 698.3±0.92ns 695.4±0.32ns -0.42%
decimal::pow/rust-native 663.4±0.48ns 670.2±1.07ns +1.03%
decimal::pow/wasmi 59.5±0.16µs 58.6±0.33µs -1.51%
decimal::pow/wasmi-call-native 2.5±0.00µs 2.4±0.01µs -4.00%
decimal::root/0 8.1±0.05µs 7.9±0.01µs -2.47%
decimal::sub/0 8.2±0.00ns 8.4±0.01ns +2.44%
decimal::to_string/0 434.2±0.35ns 451.2±0.32ns +3.92%
precise_decimal::add/0 9.0±0.04ns 8.8±0.04ns -2.22%
precise_decimal::add/rust-native 10.9±0.05ns 10.9±0.03ns 0.00%
precise_decimal::add/wasmi 285.6±1.00ns 284.1±1.40ns -0.53%
precise_decimal::add/wasmi-call-native 2.8±0.00µs 2.8±0.01µs 0.00%
precise_decimal::div/0 334.4±2.49ns 320.8±1.49ns -4.07%
precise_decimal::from_string/0 204.0±0.25ns 202.9±0.37ns -0.54%
precise_decimal::mul/0 376.7±1.64ns 362.1±0.81ns -3.88%
precise_decimal::mul/rust-native 321.0±2.05ns 317.1±0.29ns -1.21%
precise_decimal::mul/wasmi 34.5±0.41µs 35.5±0.07µs +2.90%
precise_decimal::mul/wasmi-call-native 3.2±0.01µs 3.2±0.01µs 0.00%
precise_decimal::pow/0 1918.8±1.41ns 1943.7±1.82ns +1.30%
precise_decimal::pow/rust-native 1547.4±6.41ns 1524.1±3.48ns -1.51%
precise_decimal::pow/wasmi 166.6±1.40µs 170.6±0.41µs +2.40%
precise_decimal::pow/wasmi-call-native 5.7±0.00µs 5.7±0.00µs 0.00%
precise_decimal::root/0 57.3±0.04µs 56.9±0.03µs -0.70%
precise_decimal::sub/0 9.1±0.08ns 9.1±0.32ns 0.00%
precise_decimal::to_string/0 707.4±1.56ns 693.8±0.75ns -1.92%
schema::validate_payload 381.7±0.61µs 379.6±0.58µs -0.55%
transaction::radiswap 5.2±0.02ms 5.2±0.02ms 0.00%
transaction::transfer 1969.9±5.74µs 1917.0±6.38µs -2.69%
transaction_processing::prepare 2.5±0.00ms 2.5±0.00ms 0.00%
transaction_processing::prepare_and_decompile 6.2±0.04ms 6.1±0.02ms -1.61%
transaction_processing::prepare_and_decompile_and_recompile 24.8±0.14ms 32.4±0.34ms +30.65%
transaction_validation::validate_manifest 42.8±0.16µs 42.6±0.48µs -0.47%
transaction_validation::verify_bls_2KB 1014.4±24.85µs 1000.8±3.63µs -1.34%
transaction_validation::verify_bls_32B 1000.7±4.91µs 1000.9±3.98µs +0.02%
transaction_validation::verify_ecdsa 74.8±0.05µs 74.7±0.38µs -0.13%
transaction_validation::verify_ed25519 55.4±0.11µs 55.6±0.05µs +0.36%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant