-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Better align NativeProof
/ NativeBucket
functionality with Scrypto
#1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhedey
force-pushed
the
tweak/native-bucket-improvements
branch
from
July 24, 2024 16:01
f40d07f
to
08ad00a
Compare
Docker tags |
Benchmark for 0454466Click to view benchmark
|
dhedey
force-pushed
the
tweak/native-bucket-improvements
branch
from
August 7, 2024 08:43
ae8529c
to
9cb53be
Compare
dhedey
changed the title
fix: Better align NativeProof / NativeBucket functionality with Scrypto
fix: Better align Aug 7, 2024
NativeProof
/ NativeBucket
functionality with Scrypto
talekhinezh
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After reports from a user on Telegram struggling with the
TestEnvironment
, and observing some issues usingFungibleBucket
/NonFungibleBucket
in Radquest, this fixes:FungibleBucket
andNonFungibleBucket
to have features like.resource_manager()
and not need manually converting into aBucket
.native-sdk
'sResourceManager
andscrypto-test
'sResourceBuilder
to returnFungibleBucket
/NonFungibleBucket
from relevant methodsBuilds on top of
system-api-interface-refactor
#1857 (and actually motivated it).Note this PR doesn't fully split fungible/non-fungible-specific functionality out of
NativeBucket
andNativeProof
as those would be breaking changes - but maybe we should; as I have introduced breaking changes toResourceBuilder
andResourceManager
to make them easier to use.