Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata tests to use compiled assets #1797

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

iamyulong
Copy link
Member

Summary

CI is failing when the metadata tests try to compile scenario assets. Example: https://github.com/radixdlt/radixdlt-scrypto/actions/runs/8932039773/job/24535207622?pr=1794

This PR resolves the CI issue by loading the compiled artifacts.

We may consider bumping the dependency of the source blueprints in future.

Copy link

github-actions bot commented May 3, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:a1412f3883

Copy link

github-actions bot commented May 3, 2024

Benchmark for a1412f3

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 68.0±0.81ms 67.8±0.69ms -0.29%
costing::decode_sbor 10.8±0.13µs 10.9±0.03µs +0.93%
costing::decode_sbor_bytes 29.5±0.28µs 29.6±0.13µs +0.34%
costing::deserialize_wasm 1267.7±15.36µs 1279.0±3.68µs +0.89%
costing::instantiate_flash_loan 3.6±0.51ms 5.6±0.05ms +55.56%
costing::instantiate_radiswap 5.6±0.04ms 5.6±0.06ms 0.00%
costing::spin_loop 22.5±0.48ms 22.8±0.25ms +1.33%
costing::validate_sbor_payload 29.1±0.36µs 29.4±0.21µs +1.03%
costing::validate_sbor_payload_bytes 238.9±2.92ns 241.3±1.50ns +1.00%
costing::validate_secp256k1 75.0±0.87µs 76.4±0.05µs +1.87%
costing::validate_wasm 38.9±0.44ms 39.2±0.24ms +0.77%
decimal::add/0 8.3±0.07ns 8.4±0.00ns +1.20%
decimal::add/rust-native 9.7±0.08ns 9.8±0.01ns +1.03%
decimal::add/wasmer 114.0±1.26ns 115.4±0.53ns +1.23%
decimal::add/wasmer-call-native 485.0±4.31ns 487.3±0.68ns +0.47%
decimal::add/wasmi 633.3±5.10ns 644.1±2.92ns +1.71%
decimal::add/wasmi-call-native 6.7±0.06µs 6.7±0.02µs 0.00%
decimal::div/0 188.9±1.56ns 190.8±0.15ns +1.01%
decimal::from_string/0 149.3±1.46ns 151.7±0.22ns +1.61%
decimal::mul/0 139.5±1.44ns 141.8±0.23ns +1.65%
decimal::mul/rust-native 134.6±1.25ns 136.3±0.17ns +1.26%
decimal::mul/wasmer 1499.1±11.41ns 1522.4±1.87ns +1.55%
decimal::mul/wasmer-call-native 603.1±5.69ns 626.9±0.52ns +3.95%
decimal::mul/wasmi 53.4±0.32µs 53.6±0.22µs +0.37%
decimal::mul/wasmi-call-native 6.7±0.08µs 6.8±0.02µs +1.49%
decimal::pow/0 640.1±8.26ns 650.1±2.18ns +1.56%
decimal::pow/rust-native 616.9±5.24ns 627.3±0.79ns +1.69%
decimal::pow/wasmer 6.6±0.05µs 6.6±0.00µs 0.00%
decimal::pow/wasmer-call-native 1031.5±9.87ns 1052.1±0.64ns +2.00%
decimal::pow/wasmi 251.7±1.59µs 252.2±1.01µs +0.20%
decimal::pow/wasmi-call-native 6.4±0.04µs 6.4±0.00µs 0.00%
decimal::root/0 7.8±0.06µs 8.2±0.01µs +5.13%
decimal::sub/0 8.2±0.06ns 8.3±0.01ns +1.22%
decimal::to_string/0 429.0±2.75ns 432.3±0.30ns +0.77%
precise_decimal::add/0 9.3±0.07ns 9.4±0.01ns +1.08%
precise_decimal::add/rust-native 11.3±0.12ns 11.4±0.00ns +0.88%
precise_decimal::add/wasmer 118.4±0.70ns 117.5±0.39ns -0.76%
precise_decimal::add/wasmer-call-native 517.7±6.03ns 520.9±0.30ns +0.62%
precise_decimal::add/wasmi 825.0±8.48ns 829.7±2.93ns +0.57%
precise_decimal::add/wasmi-call-native 8.2±0.06µs 8.4±0.01µs +2.44%
precise_decimal::div/0 302.6±2.06ns 307.4±0.37ns +1.59%
precise_decimal::from_string/0 183.4±1.56ns 186.9±0.26ns +1.91%
precise_decimal::mul/0 348.5±3.47ns 353.1±0.41ns +1.32%
precise_decimal::mul/rust-native 315.1±2.59ns 311.2±0.47ns -1.24%
precise_decimal::mul/wasmer 3.5±0.02µs 3.5±0.00µs 0.00%
precise_decimal::mul/wasmer-call-native 854.4±2.60ns 841.5±1.45ns -1.51%
precise_decimal::mul/wasmi 134.6±1.14µs 135.8±0.25µs +0.89%
precise_decimal::mul/wasmi-call-native 8.6±0.07µs 8.8±0.02µs +2.33%
precise_decimal::pow/0 1887.1±17.01ns 1899.7±3.54ns +0.67%
precise_decimal::pow/rust-native 1484.3±2.61ns 1492.9±4.14ns +0.58%
precise_decimal::pow/wasmer 16.3±0.16µs 16.6±0.02µs +1.84%
precise_decimal::pow/wasmer-call-native 2.2±0.02µs 2.2±0.01µs 0.00%
precise_decimal::pow/wasmi 650.0±5.50µs 659.3±0.57µs +1.43%
precise_decimal::pow/wasmi-call-native 15.7±0.09µs 15.9±0.07µs +1.27%
precise_decimal::root/0 55.0±0.56µs 57.1±0.04µs +3.82%
precise_decimal::sub/0 8.9±0.09ns 9.1±0.00ns +2.25%
precise_decimal::to_string/0 711.2±5.19ns 720.3±0.59ns +1.28%
schema::validate_payload 308.2±3.53µs 308.6±0.87µs +0.13%
transaction::radiswap 5.5±0.07ms 5.6±0.06ms +1.82%
transaction::transfer 1765.7±6.22µs 1774.8±19.15µs +0.52%
transaction_processing::prepare 2.2±0.02ms 2.2±0.02ms 0.00%
transaction_processing::prepare_and_decompile 6.1±0.02ms 6.0±0.07ms -1.64%
transaction_processing::prepare_and_decompile_and_recompile 24.8±1.19ms 23.7±0.28ms -4.44%
transaction_validation::validate_manifest 42.5±0.05µs 42.0±0.47µs -1.18%
transaction_validation::verify_bls_2KB 1049.3±111.88µs 966.0±8.43µs -7.94%
transaction_validation::verify_bls_32B 1058.9±79.23µs 964.0±7.79µs -8.96%
transaction_validation::verify_ecdsa 74.3±0.08µs 73.6±0.82µs -0.94%
transaction_validation::verify_ed25519 55.1±0.32µs 54.7±0.61µs -0.73%

@iamyulong iamyulong merged commit eb3553f into develop May 3, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants