Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin rust version #1796

Merged
merged 1 commit into from
May 3, 2024
Merged

Pin rust version #1796

merged 1 commit into from
May 3, 2024

Conversation

0xOmarA
Copy link
Member

@0xOmarA 0xOmarA commented May 3, 2024

Summary

Pins the rust version to 1.77.2 due to an issue with 1.78.0 and wasmer

@0xOmarA 0xOmarA changed the title fix: pin rust version Pin rust version May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:db129e9b63

Copy link

github-actions bot commented May 3, 2024

Benchmark for db129e9

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 65.5±0.18ms 65.9±0.14ms +0.61%
costing::decode_sbor 10.9±0.04µs 10.9±0.12µs 0.00%
costing::decode_sbor_bytes 30.0±0.17µs 29.1±0.03µs -3.00%
costing::deserialize_wasm 1306.1±2.95µs 1293.1±9.46µs -1.00%
costing::instantiate_flash_loan 3.7±0.46ms 3.8±0.44ms +2.70%
costing::instantiate_radiswap 5.6±0.05ms 6.0±0.06ms +7.14%
costing::spin_loop 21.4±0.04ms 21.4±0.05ms 0.00%
costing::validate_sbor_payload 29.5±0.05µs 29.9±0.05µs +1.36%
costing::validate_sbor_payload_bytes 258.6±1.10ns 247.2±0.49ns -4.41%
costing::validate_secp256k1 76.3±0.72µs 76.3±0.34µs 0.00%
costing::validate_wasm 36.6±0.04ms 36.7±0.04ms +0.27%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.01ns 9.8±0.01ns 0.00%
decimal::add/wasmer 121.0±0.70ns 113.2±0.09ns -6.45%
decimal::add/wasmer-call-native 454.6±1.97ns 454.8±0.69ns +0.04%
decimal::add/wasmi 611.2±0.62ns 610.0±1.68ns -0.20%
decimal::add/wasmi-call-native 5.3±0.02µs 5.2±0.01µs -1.89%
decimal::div/0 190.1±0.20ns 190.7±0.19ns +0.32%
decimal::from_string/0 152.2±0.10ns 152.5±0.30ns +0.20%
decimal::mul/0 142.0±0.05ns 140.6±0.17ns -0.99%
decimal::mul/rust-native 137.8±0.13ns 137.9±0.08ns +0.07%
decimal::mul/wasmer 1494.8±0.39ns 1526.5±1.63ns +2.12%
decimal::mul/wasmer-call-native 586.9±0.56ns 611.9±1.70ns +4.26%
decimal::mul/wasmi 40.9±0.05µs 41.4±0.21µs +1.22%
decimal::mul/wasmi-call-native 5.4±0.00µs 5.4±0.00µs 0.00%
decimal::pow/0 651.3±1.27ns 651.5±0.73ns +0.03%
decimal::pow/rust-native 630.5±0.85ns 629.0±0.46ns -0.24%
decimal::pow/wasmer 6.5±0.00µs 6.6±0.00µs +1.54%
decimal::pow/wasmer-call-native 1023.6±0.90ns 1024.0±0.63ns +0.04%
decimal::pow/wasmi 194.7±0.29µs 195.4±0.31µs +0.36%
decimal::pow/wasmi-call-native 5.2±0.01µs 5.3±0.01µs +1.92%
decimal::root/0 8.0±0.01µs 7.9±0.02µs -1.25%
decimal::sub/0 8.5±0.01ns 8.5±0.01ns 0.00%
decimal::to_string/0 442.7±0.87ns 440.3±3.50ns -0.54%
precise_decimal::add/0 10.0±0.00ns 10.0±0.01ns 0.00%
precise_decimal::add/rust-native 11.4±0.00ns 11.4±0.00ns 0.00%
precise_decimal::add/wasmer 126.7±0.15ns 126.4±0.29ns -0.24%
precise_decimal::add/wasmer-call-native 493.4±1.54ns 492.5±0.42ns -0.18%
precise_decimal::add/wasmi 768.3±1.25ns 769.8±1.32ns +0.20%
precise_decimal::add/wasmi-call-native 6.8±0.01µs 6.8±0.03µs 0.00%
precise_decimal::div/0 300.6±0.31ns 300.4±0.28ns -0.07%
precise_decimal::from_string/0 195.2±0.21ns 195.4±0.12ns +0.10%
precise_decimal::mul/0 357.8±2.94ns 354.9±2.59ns -0.81%
precise_decimal::mul/rust-native 302.4±1.36ns 301.2±0.94ns -0.40%
precise_decimal::mul/wasmer 3.4±0.01µs 3.4±0.00µs 0.00%
precise_decimal::mul/wasmer-call-native 819.1±1.65ns 847.7±1.53ns +3.49%
precise_decimal::mul/wasmi 106.1±0.23µs 108.3±0.14µs +2.07%
precise_decimal::mul/wasmi-call-native 7.2±0.01µs 7.2±0.02µs 0.00%
precise_decimal::pow/0 1859.4±3.99ns 1854.4±3.32ns -0.27%
precise_decimal::pow/rust-native 1483.5±3.16ns 1483.5±3.86ns 0.00%
precise_decimal::pow/wasmer 16.1±0.02µs 16.1±0.01µs 0.00%
precise_decimal::pow/wasmer-call-native 2.1±0.00µs 2.1±0.00µs 0.00%
precise_decimal::pow/wasmi 514.2±0.67µs 511.6±0.70µs -0.51%
precise_decimal::pow/wasmi-call-native 13.3±0.08µs 13.1±0.02µs -1.50%
precise_decimal::root/0 56.7±0.03µs 55.8±0.01µs -1.59%
precise_decimal::sub/0 9.5±0.01ns 9.5±0.02ns 0.00%
precise_decimal::to_string/0 725.6±3.20ns 734.1±3.48ns +1.17%
schema::validate_payload 343.3±1.86µs 343.1±0.28µs -0.06%
transaction::radiswap 5.5±0.03ms 5.4±0.02ms -1.82%
transaction::transfer 1766.7±4.19µs 1749.8±9.84µs -0.96%
transaction_processing::prepare 2.2±0.00ms 2.2±0.00ms 0.00%
transaction_processing::prepare_and_decompile 6.1±0.01ms 6.0±0.01ms -1.64%
transaction_processing::prepare_and_decompile_and_recompile 23.8±0.11ms 25.0±1.73ms +5.04%
transaction_validation::validate_manifest 42.1±0.08µs 42.2±0.05µs +0.24%
transaction_validation::verify_bls_2KB 978.0±15.07µs 1012.6±46.22µs +3.54%
transaction_validation::verify_bls_32B 1004.9±42.63µs 1121.1±185.00µs +11.56%
transaction_validation::verify_ecdsa 74.2±0.08µs 74.2±0.41µs 0.00%
transaction_validation::verify_ed25519 54.7±0.17µs 54.7±0.09µs 0.00%

@0xOmarA 0xOmarA merged commit 10cbd49 into develop May 3, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants