-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify customization of protocol updates and align better with node #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhedey
force-pushed
the
tweak/protocol-update-builders
branch
from
April 28, 2024 18:37
4cade4d
to
82d0c7a
Compare
Docker tags |
Benchmark for 5fc839cClick to view benchmark
|
dhedey
commented
Apr 30, 2024
0xOmarA
reviewed
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did an initial review and pushed some comments.
iamyulong
reviewed
May 1, 2024
iamyulong
reviewed
May 2, 2024
iamyulong
approved these changes
May 2, 2024
…-regeneration chore: Regenerate all transaction scenario dumps
0xOmarA
force-pushed
the
tweak/protocol-update-builders
branch
from
May 2, 2024 18:28
76e1f4a
to
3807785
Compare
0xOmarA
force-pushed
the
tweak/protocol-update-builders
branch
from
May 3, 2024 09:52
98eb2a0
to
312ad9a
Compare
This reverts commit b4628f2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The aim is to simplify configuring custom protocol versions and (importantly) align this with the node.
ProtocolBuilder
/ProtocolExecutor
TransactionScenarioExecutor
NOTE: To avoid polluting this PR, I've moved the regeneration to See #1789, which should be merged into this one before merging this into develop.
Natural / Easy Extensions
The following are all rather quick and easy, but I might not have time to do them now, and I'm splitting them out to avoid this PR getting too big:
Future extensions:
HashOfProtocolSettings => PostBootstrapClonableInMemoryDb
in LedgerSimulator, to allow tests to run faster by skipping protocol initialization.Testing
See the generated scenarios.
Update Recommendations
For dApp Developers
Transaction receipts now include state updates.
For Internal Integrators - Node
We can now use the following and map that to the BatchGenerator on the node side:
(It was designed to align with Anemone/Bottlenose as-is on node's
release/bottlenose
branch)