-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all factor sources screens #1303
Open
giannis-rdx
wants to merge
16
commits into
main
Choose a base branch
from
feature/all-factor-sources-screens
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
click factor source item
…ctorSourceButtonContent
…d screen to use FactorSourceCard and moved screen to securityfactors package
micbakos-rdx
approved these changes
Jan 10, 2025
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Initially, the idea was to introduce a single generic screen and ViewModel for all factor source screens (e.g., Biometrics/PIN, Arculus Card, etc.). However, this approach didn’t work well because each factor source type either already has, or might later require, business logic specific to its type. For example, consider LedgerDevicesViewModel, which contains business logic related to linked connectors.
To avoid spending more time trying to figure out ‘generic’ ideas or patterns, I opted for a simpler and faster approach: one ViewModel and screen per factor source type. This approach leverages some already implemented shared logic, such as composables and the newly introduced
GetFactorSourcesOfTypeUseCase
in this PR.How to test
Video
paste link here
PR submission checklist