example: More powerful non fungible ids query #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhedey
force-pushed
the
example/more-powerful-non-fungible-ids-query
branch
from
6eeee82 to
c80bbe3
Compare
dhedey
force-pushed
the
tweak/fix-docs-and-formatting
branch
from
01b5ace to
efe6f02
Compare
krzlabrdx
reviewed
Aug 13, 2024
| @@ -76,6 +76,9 @@ private EntityAddress(string address) | |||
| _address = address; | |||
| } | |||
|
|
|||
| // See https://radixdlt.atlassian.net/wiki/spaces/S/pages/3045556302/REP-71+-+Address+Formats+and+Vanity+Addresses | |||
| public bool IsNonFungibleResource => _address.Contains("1ng") || _address.Contains("1nf") || _address.Contains("1n2") || _address.Contains("1nt"); | |||
There was a problem hiding this comment.
- Guess we shouldn't link to non-public resources?
- Are you sure this is safe? Is it guaranteed that say
1ngsubstring won't be observed inpackage_1loc2dsadaxxxx1ngdasdasdasor something?
There was a problem hiding this comment.
- I'm okay with it, but can change it to
REP-71if we'd rather - Yes it is; but we can do it as an entity byte check if you'd rather change
EntityAddressto work over a toolkit address
dhedey
force-pushed
the
example/more-powerful-non-fungible-ids-query
branch
from
c80bbe3 to
4582fb4
Compare
Fix include value and include deleted flags
|
PawelPawelec-RDX
force-pushed
the
develop
branch
from
9ce1552 to
6d0ea94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(Untested, we can test when rebasing onto develop)
Details
Demonstrates a pretty generic and highly performant wrapper around the
definitions / entriesqueries.Testing
Needs testing