Adding tags parameters with radapp defaults to Azure Recipes

[willvelida]

Responding to #53, adding tags to Azure Recipes as parameters.

[willvelida]

@AaronCrawfis - If you have any feedback for me, let me know 🙂

[rynowak]

@AaronCrawfis did you want these to be the names or ids? We used names here

For @willvelida the id will be a long string like /planes/radius/local/..../Applications.Core/applications/my-cool-app.

The name will be my-cool-app.

There's also a special-case to handle where the application can be null. You can see how we handled that here: https://github.com/radius-project/recipes/blob/main/local-dev/rabbitmqqueues.bicep#L60

[AaronCrawfis]

did you want these to be the names or ids?

Since these are going to be used to identify an application within the Azure portal and not used for programmatic matching within a namespace, my preference is IDs. That way you can fully identity what's using this resource.

[willvelida]

@rynowak @AaronCrawfis I've kept the IDs in, but I've added null checking for the application. Hopefully this meets both requirements? 🙂

[AaronCrawfis]

Idk if we want to make this a raw parameter. In the current design if I wanted to set my own tags I'd be removing the radapp.io tags, even though that might not be my intention. Instead, you could instead use the union function to offer a tags parameter, and then union it with the set of radapp.io tags so you get both behaviors: https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/bicep-functions-array#union

[willvelida]

I've updated the bicep files to change the tags to variables, add another parameter for tags that the user may want to provide and used the union function to apply them both.

[AaronCrawfis]

Just attempted to deploy this Recipe and got this error message:

{
          "code": "RecipeDeploymentFailed",
          "message": "failed to deploy recipe default of type Applications.Dapr/stateStores",
          "details": [
            {
              "code": "DeploymentFailed",
              "message": "At least one resource deployment operation failed. Please see the details for the specific operation that failed.",
              "target": "/planes/radius/local/resourceGroups/default/providers/Microsoft.Resources/deployments/recipe1707868070557672174",
              "details": [
                {
                  "code": "InvalidTagNameCharacters",
                  "message": "The tag names 'radapp.io/application, radapp.io/environment, radapp.io/resource' have reserved characters '\u003c,\u003e,%,\u0026,\\,?,/' or control characters. These characters are only allowed for tags that start with the prefix 'hidden, link'.",
                  "target": "/subscriptions/66d1209e-1382-45d3-99bb-650e6bf63fc0/resourcegroups/aacrawfi/providers/Microsoft.Storage/storageAccounts/recipe2lkqwvspyl24g"
                }
              ]
            }

Looking in the Azure portal I also get the same error message:

We should switch to using another character, maybe -? (radapp.io-application)

cc/ @rynowak

[willvelida]

@AaronCrawfis I've changed the character now to a hyphen :)

Question - Do the tests just work for the local recipes? If so, could we introduce tests to test the Azure/AWS recipes as part of the workflow? Initially I thought using ephemeral environments for each cloud to do this, but not 100% on this.

[AaronCrawfis]

Thanks! Currently yes, we just test local-dev Recipes as we can run them in-cluster without needing external cloud resources. We do want to add full integration tests for cloud resources, we just haven't gotten it setup yet. I opened #62 to track this work.

[AaronCrawfis]

Looks great, thanks!!