Fix container name in Dapr component #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Crawfis <[email protected]>
kachawla
approved these changes
Jan 22, 2024
Reshrahim
pushed a commit
to Reshrahim/recipes
that referenced
this pull request
Feb 23, 2024
Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]>
kachawla
added a commit
that referenced
this pull request
Feb 27, 2024
* Fix container name (#58) Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> * Adding tags parameters with radapp defaults to Azure Recipes (#60) * Adding tags parameters with radapp defaults to Azure Recipes Signed-off-by: Will Velida <[email protected]> * Add radius-specific tags with optional tag parameters. null checking on application context in tag Signed-off-by: Will Velida <[email protected]> * Adding hyphen character in radiusTags object Signed-off-by: Will Velida <[email protected]> --------- Signed-off-by: Will Velida <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add contribution guides Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add contribution link Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add contribution link Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add links to contribution guides to code and PR Signed-off-by: Reshma Abdul Rahim <[email protected]> * Rename contribution folder Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add links to contribution guides to code and PR Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add testing steps Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add testing steps Signed-off-by: Reshma Abdul Rahim <[email protected]> * close bicep code snippet Signed-off-by: Reshma Abdul Rahim <[email protected]> * Delete .DS_Store Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> * Address feedback Signed-off-by: Reshma Abdul Rahim <[email protected]> * Update docs/contributing/contributing-recipes.md Co-authored-by: Aaron Crawfis <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> * Address feedback Signed-off-by: Reshma Abdul Rahim <[email protected]> * Update publish in test workflow to exclude readme file) Signed-off-by: Reshma Abdul Rahim <[email protected]> * Empty-Commit Signed-off-by: Reshma Abdul Rahim <[email protected]> * Update aws/README.MD Co-authored-by: Karishma Chawla <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> * Apply suggestions from code review Co-authored-by: Karishma Chawla <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> * Address feedback Signed-off-by: Reshma Abdul Rahim <[email protected]> * Address feedback Signed-off-by: Reshma Abdul Rahim <[email protected]> * Address feedback Signed-off-by: Reshma Abdul Rahim <[email protected]> * Address feedback Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add hyperlink Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add hyperlink Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Will Velida <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> Co-authored-by: Will Velida <[email protected]> Co-authored-by: Karishma Chawla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a naming issue for the Dapr component in the Azure Dapr state store Recipes
Previously we referenced the name of the container directly, which returned
<accountName>/default/<containerName>instead of just<containerName>.This PR creates a var and both names and references the value directly.