-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ubuntu-latest
instead of a hosted 4-core runner
#7973
base: main
Are you sure you want to change the base?
Conversation
Thanks @jeefy - approved the workflows so we can test this out! |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7973 +/- ##
=======================================
Coverage 60.63% 60.63%
=======================================
Files 534 534
Lines 28484 28484
=======================================
Hits 17271 17271
Misses 9697 9697
Partials 1516 1516 ☔ View full report in Codecov by Sentry. |
Thank you @jeefy ! https://github.com/radius-project/radius/actions/runs/11110614862/job/30941845181?pr=7973 We may have to stay with |
@jeefy - any ideas? We're using |
01bb0bf
to
b407aba
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
That could be the reason why one of our functional tests is failing. |
Signed-off-by: Jeffrey Sica <[email protected]>
b407aba
to
58ba102
Compare
They have the same amount of RAM, but the disk space is different (free runner: 14GB, non-free... 140GB) I'm going to update the PR to use one of our hosted runners since it has more disk. |
Signed-off-by: Jeffrey Sica <[email protected]>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Don't know why the job isn't getting picked up, and I watched other jobs outside of this repo during this. I'll have to investigate further. Thanks! |
Description
Heya! Friendly neighborhood CNCF staffer here. The ubuntu-latest runner is already a 4-core runner, so using a hosted 4-core runner is unnecessary (and actually costs money). This PR just swaps any 4-core hosted runners to use ubuntu-latest. There should be zero change or impact, functionally this is a SKU change.
Please reach out to me in the CNCF/K8s slack(s) (jeefy) or via email ([email protected]) with any questions.
Type of change
Replaces
ubuntu-latest-m
(which is a pay-for 4-core hosted runner) toubuntu-latest
(which is the free 4-core runner with no real spec difference)