Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating doc to use DE from existing installation #7964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nithyatsu
Copy link
Contributor

Description

deployment-engine is currently a private repo. Updating contributor docs to use DE from existing installation.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

@nithyatsu nithyatsu requested review from a team as code owners September 25, 2024 19:38
"KUBERNETESBICEPEXTENSIBILITYURL": "http://localhost:5017/api",
"RADIUSBACKENDURI": "http://localhost:9000",
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave this here? It's still useful.

That gives users the choice of either:

  • Using the DE from a cluster
  • Using the DE from local source code

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.11%. Comparing base (2df79ec) to head (053fc7a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7964      +/-   ##
==========================================
- Coverage   61.13%   61.11%   -0.02%     
==========================================
  Files         533      533              
  Lines       28248    28248              
==========================================
- Hits        17269    17265       -4     
- Misses       9462     9464       +2     
- Partials     1517     1519       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Sep 30, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository nithyatsu/radius
Commit ref 053fc7a
Unique ID func1aa52fd8f9
Image tag pr-func1aa52fd8f9
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1aa52fd8f9
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1aa52fd8f9
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func1aa52fd8f9
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1aa52fd8f9
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants