-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating typespec version and tsp files #7939
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7939 +/- ##
==========================================
- Coverage 60.37% 60.36% -0.01%
==========================================
Files 560 560
Lines 29417 29417
==========================================
- Hits 17761 17759 -2
- Misses 10111 10112 +1
- Partials 1545 1546 +1 ☔ View full report in Codecov by Sentry. |
283d15e
to
1313629
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
kind: CustomResourceDefinition | |||
metadata: | |||
annotations: | |||
controller-gen.kubebuilder.io/version: v0.15.0 | |||
controller-gen.kubebuilder.io/version: v0.16.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this needs to change in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because of my local controller-gen version. I can revert this change. But before this PR (#7928) gets merged in we have to do the update. Please see: #7928 (comment).
1313629
to
3bb9622
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
cmd/rad/cmd/bicepDownload.go
Outdated
@@ -30,7 +28,7 @@ var bicepDownloadCmd = &cobra.Command{ | |||
Short: "Download the bicep compiler", | |||
Long: `Downloads the bicep compiler locally`, | |||
RunE: func(cmd *cobra.Command, args []string) error { | |||
output.LogInfo(fmt.Sprintf("Downloading Bicep for channel %s...", version.Channel())) | |||
output.LogInfo("Downloading Bicep for channel %s...", version.Channel()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New version of golangci-lint
was complaining about these: https://golangci-lint.run/welcome/install/#other-ci.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ytimocin can you separate this change from the typespec update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did. I will rebase this once the other PR is in.
@@ -73,7 +73,7 @@ func (src *DaprConfigurationStoreResource) ConvertTo() (v1.DataModelInterface, e | |||
if src.Properties.Recipe != nil && (!reflect.ValueOf(*src.Properties.Recipe).IsZero()) { | |||
msgs = append(msgs, "recipe details cannot be specified when resourceProvisioning is set to manual") | |||
} | |||
if src.Properties.Metadata == nil || len(src.Properties.Metadata) == 0 { | |||
if len(src.Properties.Metadata) == 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golangci-lint
was complaining about this saying that first check was unnecessary.
3bb9622
to
09f7626
Compare
09f7626
to
83e67f1
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
83e67f1
to
e16cf6f
Compare
f8268db
to
9ebe272
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
9ebe272
to
27717eb
Compare
04efba0
to
a68598f
Compare
a68598f
to
525bbde
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
525bbde
to
67eb645
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
67eb645
to
50a68c8
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
50a68c8
to
aba3310
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
aba3310
to
3ca6412
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
3ca6412
to
d4b67b3
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
||
// This was added because typespec doesn't generate necessary functions and other variables for single value enums. | ||
// This can be deleted if we add more values to the enum. | ||
string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a tracking issue for this in the typespec repo we can refer to here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed. separate issue will be opened to update autorest version in radius project which may alleviate this issue.
… of the version update Signed-off-by: ytimocin <[email protected]>
d4b67b3
to
a5df56e
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
Updating typespec version and some tsp files with that version update.
Type of change
Fixes: #issue_number