Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CJS export #109

Merged
merged 10 commits into from
Feb 18, 2024
Merged

Fix CJS export #109

merged 10 commits into from
Feb 18, 2024

Conversation

radiovisual
Copy link
Owner

@radiovisual radiovisual commented Nov 23, 2023

  • Added CJS as the main export type, keeping support for ES modules and UMD
  • Will require a major version update
  • Adds missing URL patterns to README
  • Updates unit tests
  • Update github actions
  • Returns undefined instead of null when ids can't be found
  • Updates CI routines
  • Updates packages
  • Cleaned up the code more, added dedicated helpers to clean up side effects

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71d3fbb) 100.00% compared to head (92407c8) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #109   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9        11    +2     
  Lines          393       436   +43     
=========================================
+ Hits           393       436   +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radiovisual radiovisual merged commit eafa37e into master Feb 18, 2024
8 checks passed
@radiovisual radiovisual deleted the misc-updates branch February 18, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants