feat(output): SMC title data delivery #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairmare
force-pushed
the
feat/initial-smc-ftp-support
branch
2 times, most recently
from
b622519 to
7151774
Compare
hairmare
force-pushed
the
feat/initial-smc-ftp-support
branch
5 times, most recently
from
3d3ece6 to
36587ba
Compare
hairmare
force-pushed
the
feat/initial-smc-ftp-support
branch
from
36587ba to
8cf9fd7
Compare
hairmare
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is mostly based on the existing DabAudioCompanion integration. The code is a bit MVP-ish but should get us up and running with feature parity compared to our existing provider.
The FTP integration supports
ftplib.FTP_TLSstyle connections only. It uses STOR to put the required textfiles onto the server. All of this might change during actual integration + validation.