Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple search view for hosts, notes and shows #33

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from

Conversation

eigenwijsje
Copy link
Contributor

  • The search is limited to Host.name, Note.title and Show.name fields,
  • The scope of can be narrowed by specifying the types query parameter: host, note or show.
  • The view is paginated and returns a list of objects, annotated with their type,
  • The view is exposed at /v3/search/ and expects the q and handles the page parameter.

It doesn’t require any migration, it’s limited because it uses SELECT ... from ... WHERE ILIKE for the search.

@eigenwijsje eigenwijsje self-assigned this Dec 10, 2024
Copy link
Member

@equinox0815 equinox0815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Do you want me to deploy to prod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants