Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creation of binary dilation structure in masking and moments tutorial #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix creation of binary dilation structure in masking and moments tutorial #40

wants to merge 1 commit into from

Conversation

e-koch
Copy link
Collaborator

@e-koch e-koch commented Aug 5, 2024

Found a small typo when applying the binary dilation operator in the final step of creating the signal mask.

@e-koch
Copy link
Collaborator Author

e-koch commented Aug 5, 2024

Failing due to aplpy import in spectral-cube. Will need to address upstream.

keflavich
keflavich approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to add some clarification of the intent of/need for the added 'swapaxes' though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keflavich keflavich keflavich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-koch @keflavich