-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spectral-cube and CASA operations: performance comparisons #11
base: master
Are you sure you want to change the base?
Conversation
Bokeh plots are not being rendered on binder. |
@astrofrog @keflavich I've added a CASA to spectral-cube conversion tutorial for basic cube operations and fitting: Moved to #15 Everything won't work until radio-astro-tools/spectral-cube#656, radio-astro-tools/spectral-cube#665, and radio-astro-tools/spectral-cube#666 are merged in spectral-cube. The performance tutorial above is still a WIP. |
This is also noted in the tutorial and demonstrated, but I think this could be a common discrepancy users may find so I'll retiterate it here: The biggest spectral-cube to CASA difference is CASA's definition of the second moment along the spectral dimension. spectral-cube uses the correct formal definition (i.e., the variance) and then defines the sqrt as the "linewidth_sigma". If noisy lines of sight are included, some of the moment 2 values can be negative (because the variance is being weighted by negative values in places) and so the square root ends up being a In CASA, the moment2 from If you need to reproduce the CASA behaviour for the second moment in spectral-cube, use this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the output cells from the notebooks? (otherwise one of the notebooks is too large to comment on - and anyway we should not store outputs in the repo)
"\n", | ||
"## Summary ##\n", | ||
"\n", | ||
"This tutorial compares the performance of common operations in spectral-cube and CASA. This provides an idea for which operaitons in the respective packages are well optimized. The goal is also to explore how to produce equivalent comparisons since the package use different methods to parallelize operations.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I'm not sure about calling this a tutorial, maybe just referring to it as a 'notebook' would make more sense? (and linking to the other notebook in this PR for the average user)
"pip install dask\n", | ||
"pip install aplpy\n", | ||
"pip install --index-url https://casa-pip.nrao.edu/repository/pypi-casa-release/simple casatools\n", | ||
"pip install --index-url https://casa-pip.nrao.edu/repository/pypi-casa-release/simple casatasks\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put casatools and casatasks on same line, and also simplify imports above by removing ones that are redundant?
Tutorial and overview of comparing dask and CASA performance.