Test cleanup and fixes #928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keflavich
approved these changes
Oct 18, 2024
|
@keflavich FYI I'm expecting there's a few more tests to fix before this is ready. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #928 +/- ##
==========================================
- Coverage 79.84% 79.83% -0.02%
==========================================
Files 24 23 -1
Lines 6024 6020 -4
==========================================
- Hits 4810 4806 -4
Misses 1214 1214 ☔ View full report in Codecov by Sentry. |
e-koch
commented
Oct 18, 2024
|
|
||
| # This restores showing the "loading the entire cube into memory" warning for | ||
| # _apply_everywhere and _cube_on_cube_operation | ||
| if function.__name__ in ['_apply_everywhere', '_cube_on_cube_operation']: |
There was a problem hiding this comment.
@keflavich -- can you check if this is consistent with the changes you made here: cb8dfbe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing a few longer-standing test failures and ensuring things are passing with today's merging of several PRs.