-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests for numpy 2.0 #917
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #917 +/- ##
==========================================
- Coverage 79.94% 79.93% -0.02%
==========================================
Files 24 24
Lines 6013 6019 +6
==========================================
+ Hits 4807 4811 +4
- Misses 1206 1208 +2 ☔ View full report in Codecov by Sentry. |
Failures resulting from |
Removing ptp as a method fixed this issue. Remaining issues are related to the casadata package. @keflavich the fix that was working in the uvcombine doesn't seem to be working anymore |
Updating the data manually via casaconfig seems to fix the casadata path error: https://casadocs.readthedocs.io/en/stable/notebooks/external-data.html#Populating-the-Data-Directory-Manually |
@@ -105,6 +105,9 @@ def load_casa_image(filename, skipdata=False, memmap=True, | |||
elif 'beams' in beam_: | |||
bdict = beam_['beams'] | |||
|
|||
# NOTE: temp to check failing test | |||
print(desc['_keywords_']['coords']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just commenting as a reminder since this is a temp check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. still trying to figure out why the dict structure seems to have changed.
@keflavich @preshanth the tests are hitting 2 failures that seem to imply underlying changes in the image tool? I'm somewhat lost on where the change actually occurred. The current failures have 2 sources:
|
also note that the CASA builds are pinned to numpy<2.0. There were a bunch of additional errors related to a build numpy 1.X build somewhere in the casa module stack. That seems firmly upstream of handling in spectral-cube. |
On casa numpy issue. There is ongoing work to fix casa and put out an updated version. That should fix the numpy 2.0 problems. Will look at the dict when I get a chabce |
Test fixes against numpy 2.0