Deprecation fix the 2nd: replace mktemp with TemporaryDirectory

[dhomeier]

Another go at replacing the deprecated function for the save_to_tmp_dir option, with an attempt to delete the temporary files along with the cube instance.
See however discussion about using __del__ in #789 (review).

[codecov-commenter]

Codecov Report

Merging #796 (4b72221) into master (c7281a7) will decrease coverage by 0.00%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
- Coverage   78.00%   78.00%   -0.01%     
==========================================
  Files          24       24              
  Lines        5847     5850       +3     
==========================================
+ Hits         4561     4563       +2     
- Misses       1286     1287       +1     

Impacted Files	Coverage Δ
spectral_cube/dask_spectral_cube.py	85.54% <37.50%> (-0.10%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7281a7...4b72221. Read the comment docs.

[dhomeier]

Apparently the Windows test is still the only one that runs with zarr installed and not skipping the tests. Don't quite understand why, as it's also listed in the novis deps.

[keflavich]

LGTM, but I think we should hold off on merging for a minute - I'd like to do some additional tests.

In particular, I plan to by-hand load a cube, do some save_to_tmpdir operation, verify that the zarr is written to disk, delete the cube, verify that the tmpdir has been deleted. Similarly, same process, but close python w/o deleting tempdir.

Also we should probably figure out the test issue that @dhomeier noted - we should test this on each OS

[dhomeier]

Similarly, same process, but close python w/o deleting tempdir.

Good point, something I've also only tested locally under macOS. Not sure if this can be implemented in the CI – I think open_files is kind of testing this, but may not be completely equivalent. And I have no idea about tmpfile handling on Windows in general.

[keflavich]

@dhomeier could you rebase this? I think we're ready to merge even though I never did end up doing that manual test