implement APE14 compatibility in reproject #778
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
- Coverage 77.86% 77.80% -0.07%
==========================================
Files 24 24
Lines 5811 5816 +5
==========================================
Hits 4525 4525
- Misses 1286 1291 +5
Continue to review full report at Codecov.
|
|
This is not even close to straightforward. I don't think spectral-cube can or should support any non-serializable WCSes. |
keflavich
force-pushed
the
reproject_ape14
branch
from
6ffde31
to
c19679f
Compare
keflavich
force-pushed
the
reproject_ape14
branch
from
c19679f
to
ed06d88
Compare
fix some typos fix order
keflavich
force-pushed
the
reproject_ape14
branch
from
ed06d88
to
6245a5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #777
This is a fairly straightforward PR but needs tests.