Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update volume rendering code to work with more modern yt installations #586

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

jzuhone
Copy link
Contributor

@jzuhone jzuhone commented Oct 17, 2019

The API for yt's volume rendering has changed completely. This PR updates the volume rendering code for spectral cubes to reflect this.

I haven't tested this yet, so I'm marking it as WIP until I can. In the meantime, I wanted to put it up for @trhunter to play with.

Closes Issue #571.

@coveralls
Copy link

coveralls commented Oct 17, 2019

Coverage Status

Coverage decreased (-3.7%) to 84.309% when pulling 72dd5ac on jzuhone:fix_yt_camera into 31b0b51 on radio-astro-tools:master.

@jzuhone
Copy link
Contributor Author

jzuhone commented Oct 17, 2019

Ok, it runs, but the images are blank. This will probably take a little while to dig out of.

@jzuhone
Copy link
Contributor Author

jzuhone commented Oct 18, 2019

@keflavich do you have a favorite VR example that we could try out?

@keflavich
Copy link
Contributor

Not really... the GRS l=49 data were pretty good though:

https://spectral-cube.readthedocs.io/en/latest/yt_example.html#sketchfab-isosurface-contours

@jzuhone
Copy link
Contributor Author

jzuhone commented Oct 18, 2019

Is this the L1448_13CO.fits file?

@keflavich
Copy link
Contributor

No but that one is totally fine if it looks OK

@jzuhone
Copy link
Contributor Author

jzuhone commented Oct 19, 2019

So this is working now. But I'd like to add some tests and change the docs before we merge it.

@jzuhone
Copy link
Contributor Author

jzuhone commented Oct 22, 2019

Hi @keflavich this is ready to go except I cannot get the test data I generated to compare to (as .npz files) to copy correctly when installed. I've tried several of the normal tricks but nothing seems to work. Any idea what's going on here?

@jzuhone jzuhone changed the title [WIP] Update volume rendering code to work with more modern yt installations Update volume rendering code to work with more modern yt installations Oct 22, 2019
@keflavich
Copy link
Contributor

in tests/setup_package.py, you need to add *npz

@astrofrog
Copy link
Member

@jzuhone - would you be able to rebase this? If you don't have time, I'm happy to take over the PR to clean it up.

@jzuhone
Copy link
Contributor Author

jzuhone commented Jan 14, 2020

@astrofrog I can rebase it. I had trouble getting the tests to pass before, but I'll see what happens now.

@astrofrog
Copy link
Member

@jzuhone - thanks! When you rebase can you also set the minimum yt version in setup.cfg? If there are any issues with the tests I'm happy to investigate.

@keflavich
Copy link
Contributor

The failure last time was related: https://travis-ci.org/github/radio-astro-tools/spectral-cube/jobs/640107285#L635

We'll need another rebase, and maybe another small correction, to get this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants