Add dai pool #145
Merged
Add dai pool #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #128 for the special case of Dai. This token isn't fully EIP-2612 compatible, but it's used in upstream.
This PR adds a basic implementation of Dai, which is just an ERC-20 with
permit. The real Dai contract doesn't compile with modern versions of Solidity and there are no yarn packages with it already precompiled. We also need its API, which is available as a package, but it too needs old Solidity to work. An alternative would be to pull the Dai source code, compile it to a JSON and keep a copy of it in our repo. I think that with such simple contract it's clearer to maintain these few lines of code instead of a binary blob.